[11.0][NEW] website_sale_product_detail_attribute_image: new module #288

sergio-teruel · 2019-05-15T22:01:49Z

New module for display attribute image in produts detail shop view
cc @Tecnativa

sergio-teruel · 2019-05-15T22:08:21Z

I have added free images for demo data from https://www.iconfinder.com/, Where I put this images information?

pedrobaeza · 2019-05-16T08:43:17Z

Put them on CREDITS.rst

pedrobaeza · 2019-05-16T14:19:50Z

website_sale_product_detail_attribute_image/readme/DESCRIPTION.rst

@@ -0,0 +1,2 @@
+This module extends the functionality of website sale module to allow display


s/to allow/to allow to

pedrobaeza · 2019-05-16T14:20:41Z

website_sale_product_detail_attribute_image/readme/DESCRIPTION.rst

@@ -0,0 +1,2 @@
+This module extends the functionality of website sale module to allow display
+product attributes images in shop product detail.


s/product attributes images in shop product detail/images related to product attributes in e-commerce product page

pedrobaeza · 2019-05-16T14:26:12Z

website_sale_product_detail_attribute_image/models/product_attribute.py

+        string='Website detail image',
+        attachment=True,
+        help='Small-sized image of the attribute for shop online product '
+             'detail. It is automatically resized as a 64x64 px image, with '


You shouldn't resize this automatically. What about if someone wants it to 128x128? If automatic resize, you have to put a configuration option to select the preferred size.

pedrobaeza · 2019-05-16T14:26:58Z

website_sale_product_detail_attribute_image/models/product_attribute.py

+             'detail. It is automatically resized as a 64x64 px image, with '
+             'aspect ratio preserved.',
+    )
+    website_product_detail_display = fields.Boolean(


Being homogeneous with other namings, I would call this website_product_detail_image_published

pedrobaeza · 2019-05-16T14:28:31Z

website_sale_product_detail_attribute_image/controllers/main.py

+        res = super().product(
+            product, category=category, search=search, **kwargs)
+        image_attributes = product.attribute_line_ids.filtered(
+            lambda x: x.attribute_id.website_product_detail_display)


Isn't better to populate images directly:

attribute_images = product.attribute_line_ids.filtered( lambda x: x.attribute_id.website_product_detail_display ).mapped('website_product_detail_image')

I self-answer: you are also displaying the attribute name. Not sure about this being coupled between backend and frontend. It's better to have an extra translate field for website display, but fallbacking to this one if not set.

pedrobaeza · 2019-05-16T14:29:01Z

website_sale_product_detail_attribute_image/static/src/less/style.less

+}
+.product-detail-attributes div {
+    font-size: 85%;
+    /*line-height: 1;*/


Remove this if not used

pedrobaeza · 2019-05-16T14:29:12Z

website_sale_product_detail_attribute_image/tests/test_product_detail_attribute_image.py

+
+class TestProductAttribute(SavepointCase):
+    at_install = False
+    post_install = True


Is this needed?

pedrobaeza · 2019-05-16T14:30:01Z

website_sale_product_detail_attribute_image/tests/test_product_detail_attribute_image.py

+    def test_write_image_for_attribute(self):
+        self.attribute.website_product_detail_image = self.image
+        self.assertEqual(
+            self.attribute.website_product_detail_image, self.image)


This is not testing actually the resize

pedrobaeza · 2019-05-16T14:31:07Z

website_sale_product_detail_attribute_image/views/product_attribute_views.xml

+        <field name="inherit_id" ref="product.attribute_tree_view"/>
+        <field name="arch" type="xml">
+            <field name="create_variant" position="after">
+                <field name="website_product_detail_display"/>


widget switch or boolean?

pedrobaeza · 2019-05-16T14:33:30Z

website_sale_product_detail_attribute_image/views/templates.xml

+                                 t-attf-src="/web/image/product.attribute/#{image_attribute.attribute_id.id}/website_product_detail_image"/>
+                        </div>
+                        <t t-foreach="image_attribute.value_ids" t-as="value">
+                            <div class="text-center"> <span t-field="value.name"/> </div>


The same about showing these backend string here. You are not mentioning this in the README, nor the label of the attribute.

sergio-teruel · 2019-05-17T08:51:36Z

Changes done.

Tardo · 2019-05-17T14:14:56Z

website_sale_product_detail_attribute_image/views/product_attribute_views.xml

+        <field name="inherit_id" ref="product.attribute_tree_view"/>
+        <field name="arch" type="xml">
+            <field name="create_variant" position="after">
+                <field name="website_product_detail_image"/>


Why not uses widget='image' here? size?

is it working on trees?

Work but without resize image :/ perhaps can use: https://github.com/OCA/web/tree/11.0/web_tree_image

Well, maybe too much overhead for this, don't you think? Let Sergio decides.

I don't want dependencies of other modules, If the user wants to view the image only has to do click on record, also this model, once it has been configured the user not will coming back to see the images every day.
But I thought so too 😄

website_sale_product_detail_attribute_image/views/product_attribute_views.xml

sergio-teruel · 2019-05-17T21:26:54Z

Changes done

…an_widget from tree view

Tardo

LGTM, tested on runbot

OCA-git-bot · 2019-05-28T08:51:46Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rafaelbn

Tested in runbot 👍

…CA#288) * [11.0][NEW] website_sale_product_detail_attribute_image: new module * [11.0][IMP] website_sale_product_detail_attribute_image: Remove boolean_widget from tree view

sergio-teruel force-pushed the 11.0-PR-website_sale_product_detail_attribute_image branch from bf91388 to bb20c2c Compare May 15, 2019 22:29

pedrobaeza added this to the 11.0 milestone May 16, 2019

sergio-teruel force-pushed the 11.0-PR-website_sale_product_detail_attribute_image branch from bb20c2c to 1764517 Compare May 16, 2019 08:51

pedrobaeza requested changes May 16, 2019

View reviewed changes

sergio-teruel force-pushed the 11.0-PR-website_sale_product_detail_attribute_image branch from 1764517 to c0f648e Compare May 17, 2019 08:51

sergio-teruel force-pushed the 11.0-PR-website_sale_product_detail_attribute_image branch from c0f648e to f7a33e0 Compare May 17, 2019 08:55

Tardo reviewed May 17, 2019

View reviewed changes

[11.0][NEW] website_sale_product_detail_attribute_image: new module

b491d67

sergio-teruel force-pushed the 11.0-PR-website_sale_product_detail_attribute_image branch from f7a33e0 to b491d67 Compare May 17, 2019 21:23

pedrobaeza approved these changes May 17, 2019

View reviewed changes

[11.0][IMP] website_sale_product_detail_attribute_image: Remove boole…

f95ab6f

…an_widget from tree view

Tardo approved these changes May 28, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels May 28, 2019

rafaelbn approved these changes May 28, 2019

View reviewed changes

rafaelbn merged commit 4d30933 into OCA:11.0 May 28, 2019

rafaelbn deleted the 11.0-PR-website_sale_product_detail_attribute_image branch May 28, 2019 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][NEW] website_sale_product_detail_attribute_image: new module #288

[11.0][NEW] website_sale_product_detail_attribute_image: new module #288

sergio-teruel commented May 15, 2019

sergio-teruel commented May 15, 2019

pedrobaeza commented May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

pedrobaeza May 16, 2019

sergio-teruel commented May 17, 2019

Tardo May 17, 2019

pedrobaeza May 17, 2019

Tardo May 17, 2019

pedrobaeza May 17, 2019

sergio-teruel May 17, 2019

sergio-teruel commented May 17, 2019

Tardo left a comment

OCA-git-bot commented May 28, 2019

rafaelbn left a comment

		@@ -0,0 +1,2 @@
		This module extends the functionality of website sale module to allow display

		@@ -0,0 +1,2 @@
		This module extends the functionality of website sale module to allow display
		product attributes images in shop product detail.

[11.0][NEW] website_sale_product_detail_attribute_image: new module #288

[11.0][NEW] website_sale_product_detail_attribute_image: new module #288

Conversation

sergio-teruel commented May 15, 2019

sergio-teruel commented May 15, 2019

pedrobaeza commented May 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergio-teruel commented May 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergio-teruel commented May 17, 2019

Tardo left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 28, 2019

rafaelbn left a comment

Choose a reason for hiding this comment