[12.0][MIG] website_sale_product_attribute_filter_visibility #294
Conversation
…ide some product attributes in shop
…k to publish all existing attributes after install this module
…site_published True by default
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-11.0/e-commerce-11.0-website_sale_product_attribute_filter_visibility Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_product_attribute_filter_visibility/
|
Please check Travis and runbot status |
website_sale_product_attribute_filter_visibility/tests/test_attribute_filter_visibility.py
Outdated
Show resolved
Hide resolved
|
@cor9003 Is this PR ready for review?? |
|
@sergio-teruel This is the fist time I was "fighting" :-) with a testing tour and sorry but do not have experience. I have done several changes but always Mr. travis in red color. I'm sure the module is working fine but the issue for me is the tour, no experience here.... |
...ute_filter_visibility/static/src/js/website_sale_product_attribute_filter_visibility_tour.js
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0"?> | |||
| <odoo> | |||
| <template id="assets_backend" name="tour_attribute_filter" inherit_id="web.assets_backend"> | |||
There was a problem hiding this comment.
This is not correct. Backend assets are for backend interface testing, and this is not the case.
| @@ -22,7 +22,7 @@ | |||
| <record id="product_attribute_test_size" model="product.attribute"> | |||
| <field name="website_published" eval="False"/> | |||
| <field name="name">Test Size</field> | |||
| <field name="create_variant" eval="False"/> | |||
| <field name="create_variant">always</field> | |||
There was a problem hiding this comment.
Why do you need to change this demo data definition?
There was a problem hiding this comment.
data is not loaded in V12 with eval="False"
There was a problem hiding this comment.
But you could use 'none', wich follows the same logic
| @@ -6,12 +6,12 @@ | |||
| class WebsiteSaleHttpCase(HttpCase): | |||
|
|
|||
| def test_ui_website(self): | |||
| """Test frontend tour.""" | |||
| """Test tour.""" | |||
| @@ -12,5 +12,13 @@ | |||
| </field> | |||
| </field> | |||
| </record> | |||
|
|
|||
There was a problem hiding this comment.
Keep the blank line as it's more readable
|
@cor9003 Please squash the commits |
|
@sergio-teruel Done 👍 |
|
@sergio-teruel @chienandalu Sergio, David thanks a lot ! |
|
@cor9003 Ready for other ?? website_sale_product_attribute_value_filter_existing?? 😃 |
|
@sergio-teruel jajaja of course |
|
@sergio-teruel I'm going to start the migration of this module but before I would like to know how to run properly the test of the module website_sale_product_attribute_filter_visibility you did. |
|
Sorry!!, You only need enable the product attribute's filter view and run the tour in web explorer console. |
|
@sergio-teruel Sorry, I'm not able to run this test and I think I need to know how run to make successfully the other migration. After enable the product attribute's filter I get the following error: website_sale_product_attribute_filter_visibility failed at step a:contains('Customizable Desk') |
Migration to 12.0