[FIX] Only allow adding receivable entries to sale order payment #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should only be possible to link a payment/credit from a receivable account to a sale order, so filter out all other account types
|
Seems reasonable 👍 |
|
👍 |
|
👍 from me too. I have been working with Dudu on this problem together and have verified I think it is correct from an accounting perspective. |
pedrobaeza
added a commit
that referenced
this pull request
Jan 19, 2015
[FIX] Only allow adding receivable entries to sale order payment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should only be possible to link a payment/credit from a receivable account
to a sale order, so filter out all other account types
The accounting behavior doesn't make sense when it is showing all kind of entries. It should only show receivable entries.
To reproduce the bug:
1 - Go to "Quotation and Sales"
2 - Choose an order
3 - Go to "Automation Information" tab
4 - Click the Edit button
5 - Click the Add payments button
After these steps there will be receivable entries in that table, but also entries from the other side of the payment transactions, for example, the bank entry