Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][12.0] website_sale_attribute_filter_category #309

Merged
merged 5 commits into from
Nov 27, 2019
Merged

[MIG][12.0] website_sale_attribute_filter_category #309

merged 5 commits into from
Nov 27, 2019

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Oct 22, 2019 •
edited
Loading

cc @Tecnativa TT20146

sergio-teruel and others added 4 commits October 22, 2019 11:57
@sergio-teruel
[11.0][ADD] website_sale_attribute_filter_category: New module
3b8f0d1
@oca-travis @sergio-teruel
[UPD] Update website_sale_attribute_filter_category.pot
ed98264 
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_attribute_filter_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_attribute_filter_category/
@OCA-git-bot @sergio-teruel
[UPD] README.rst
ef8c30c
@oca-travis @sergio-teruel
[UPD] Update website_sale_attribute_filter_category.pot
6371469 
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_attribute_filter_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_attribute_filter_category/
@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_attribute_filter_category branch from beb0ff8 to c0bba95 Compare October 22, 2019 13:08
@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 22, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 22, 2019
Closed
19 tasks
@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_attribute_filter_category branch from c0bba95 to 24ffffb Compare October 22, 2019 17:59
@sergio-teruel sergio-teruel changed the title [WIP][MIG][12.0] website_sale_attribute_filter_category [MIG][12.0] website_sale_attribute_filter_category Oct 22, 2019
@lfreeke
Copy link

lfreeke commented Nov 15, 2019

This looks really nice, but somehow on runbot it is not working for me when trying to add the attribute groups Brand and Dimensions. I guess I do something wrong but I cannot figure out what i'm doing wrong.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 15, 2019 •
edited
Loading

@sergio-teruel please add a configuration section explaining how to add the category groups.

chienandalu
chienandalu reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergio-teruel I can't see either categories or attribute filters:
image

@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_attribute_filter_category branch from 24ffffb to d1ac3da Compare November 25, 2019 11:56
@sergio-teruel
Copy link
Contributor Author

@pedrobaeza @chienandalu Added configuration section...

@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_attribute_filter_category branch from d1ac3da to 0b885a9 Compare November 26, 2019 23:41
chienandalu
chienandalu approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot 👍 Just fix the little errata

@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_attribute_filter_category branch from 0b885a9 to 300a2ba Compare November 27, 2019 09:51
@sergio-teruel
Copy link
Contributor Author

@chienandalu Fixed!!

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-309-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2019
@OCA-git-bot
Merge PR #309 into 12.0
04132b6 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-309-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-309-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2019
@OCA-git-bot
Merge PR #309 into 12.0
4e1511d 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 300a2ba into OCA:12.0 Nov 27, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2422f40. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sergio-teruel @lfreeke @OCA-git-bot @pedrobaeza @chienandalu @rafaelbn @oca-travis