Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] website_sale_product_attribute_value_filter_existing: Migration to v.12.0 #310

Merged
merged 5 commits into from
Nov 27, 2019
Merged

[MIG] website_sale_product_attribute_value_filter_existing: Migration to v.12.0 #310

merged 5 commits into from
Nov 27, 2019

Conversation

sergio-teruel
Copy link
Contributor

cc @Tecnativa TT20149

@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_product_attribute_value_filter_existing branch from 3782af5 to 82b31e5 Compare October 22, 2019 19:44
chienandalu
chienandalu reviewed Nov 27, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this module needed anymore? From Odoo v12 runbot:
attribute-filter

@sergio-teruel
Copy link
Contributor Author

@chienandalu If you create a new duration attribute value like as "5 Year" and any product has this value, this one is hidden in website attribute's filter

chienandalu
chienandalu approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, understood 👍

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-310-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2019
@OCA-git-bot
Merge PR #310 into 12.0
424f9e6 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 27, 2019
Closed
19 tasks
@OCA-git-bot OCA-git-bot merged commit 82b31e5 into OCA:12.0 Nov 27, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 011ebb1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rafaelbn rafaelbn Awaiting requested review from rafaelbn

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sergio-teruel @pedrobaeza @OCA-git-bot @chienandalu @oca-travis