Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][12.0] website_sale_secondary_unit: Migration to v12.0 #311

Merged
merged 7 commits into from
Nov 28, 2019
Merged

[MIG][12.0] website_sale_secondary_unit: Migration to v12.0 #311

merged 7 commits into from
Nov 28, 2019

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Oct 24, 2019 •
edited
Loading

cc @Tecnativa TT20153

@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 24, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 24, 2019
Closed
19 tasks
@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_secondary_unit branch from 026b440 to 790c94d Compare October 24, 2019 10:16
@sergio-teruel sergio-teruel changed the title [WIP][MIG][12.0] website_sale_secondary_unit: Migration to v12.0 [MIG][12.0] website_sale_secondary_unit: Migration to v12.0 Oct 24, 2019
@pedrobaeza pedrobaeza requested a review from yajo October 25, 2019 15:18
@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_secondary_unit branch 2 times, most recently from cadd1d5 to c76eac9 Compare October 25, 2019 17:35
chienandalu
chienandalu approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested on runbot

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sergio-teruel sergio-teruel force-pushed the 12.0-mig-website_sale_secondary_unit branch from c76eac9 to 14e56a7 Compare November 28, 2019 17:54
@sergio-teruel
Copy link
Contributor Author

Changes done!!

@pedrobaeza pedrobaeza removed the request for review from yajo November 28, 2019 20:10
@pedrobaeza
Copy link
Member

Merging now as the Travis red flag seems the typical PhantomJS flickering:

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-311-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 28, 2019
@OCA-git-bot
Merge PR #311 into 12.0
f7acdef 
Signed-off-by pedrobaeza
@sergio-teruel
Copy link
Contributor Author

Pedro, can you take a look at travis?

@pedrobaeza
Copy link
Member

See my comment above.

@sergio-teruel
Copy link
Contributor Author

Oks...

@OCA-git-bot OCA-git-bot merged commit 14e56a7 into OCA:12.0 Nov 28, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2bdd555. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sergio-teruel @OCA-git-bot @pedrobaeza @chienandalu @oca-travis