Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12.0 mig website sale hide empty category #317

Merged
merged 5 commits into from
Apr 7, 2020
Merged

12.0 mig website sale hide empty category #317

merged 5 commits into from
Apr 7, 2020

Conversation

wpichler
Copy link
Contributor

Just splited the README into separate files and tested the functionality

Ted Salmon and others added 5 commits November 20, 2019 09:39
@wpichler
[ADD] website_sale_category_empty: Create module (OCA#342)
85bc307 
* [ADD] website_sale_category_empty: Create module
* Add module to hide categories that have no products associated with them

* [FIX] website_sale_hide_empty_category: PR Fix
* Add trailing comma to manifest
* Rename Module
@oca-travis @wpichler
[UPD] Update website_sale_hide_empty_category.pot
8f0218b
@remytms @wpichler
[MIG] website_sale_hide_empty_category: Migration to 11.0
0ac2442
@OCA-git-bot @wpichler
[ADD] icon.png
00f0ed7
@wpichler
[MIG] Migrated to Odoo 12
a237817
@oca-clabot
Copy link

Hey @wpichler, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 20, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 20, 2019
Closed
19 tasks
flotho
flotho approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chienandalu
chienandalu approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

@pedrobaeza
Copy link
Member

@chienandalu remember next time to put in your comment the TT.

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-317-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 5ef4733 into OCA:12.0 Apr 7, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e88b1c8. Thanks a lot for contributing to OCA. ❤️

@wpichler wpichler deleted the 12.0-mig-website_sale_hide_empty_category branch April 7, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotho flotho flotho approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wpichler @oca-clabot @pedrobaeza @OCA-git-bot @flotho @chienandalu @oca-travis @remytms