Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] website_sale_product_attribute_filter_visibility: Migration to 13.0 #334

Merged
merged 15 commits into from
Apr 23, 2020
Merged

[13.0][MIG] website_sale_product_attribute_filter_visibility: Migration to 13.0 #334

merged 15 commits into from
Apr 23, 2020

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Jan 30, 2020

cc @Tecnativa TT21703

@Tardo Tardo force-pushed the 13.0-mig-website_sale_product_attribute_filter_visibility branch from 69ae780 to 8d05517 Compare January 31, 2020 00:29
@sergio-teruel
Copy link
Contributor

See the website_published button
Here the product's form
Selección_563
And here the attribute's form
Selección_564

@Tardo Tardo force-pushed the 13.0-mig-website_sale_product_attribute_filter_visibility branch from 8d05517 to 32ee044 Compare February 6, 2020 18:01
@Tardo
Copy link
Member Author

Tardo commented Feb 6, 2020

Change done! Now uses 'website_publish_button' widget.

@sergio-teruel
Copy link
Contributor

@Tardo fix travis.... pre-commit... pre-commit!!! 😄

@Tardo Tardo force-pushed the 13.0-mig-website_sale_product_attribute_filter_visibility branch from 32ee044 to 6e8240a Compare February 18, 2020 19:40
@Tardo
Copy link
Member Author

Tardo commented Feb 18, 2020

Done!

@pedrobaeza pedrobaeza added this to the 13.0 milestone Feb 18, 2020
@Tardo
Copy link
Member Author

Tardo commented Mar 2, 2020

ping @chienandalu

sergio-teruel and others added 14 commits March 16, 2020 10:59
@sergio-teruel
[11.0][ADD] website_sale_product_attribute_filter_visibility: Allow h…
c243e14 
…ide some product attributes in shop
@OCA-git-bot @sergio-teruel
[UPD] README.rst
002ef78
@oca-travis @sergio-teruel
[UPD] Update website_sale_product_attribute_filter_visibility.pot
0a28794
@sergio-teruel
[11.0][IMP] website_sale_product_attribute_filter_visibility: Add hoo…
512ed58 
…k to publish all existing attributes after install this module
@sergio-teruel
[11.0][IMP] website_sale_product_attribute_filter_visibility: Set web…
afa5ba7 
…site_published True by default
@oca-travis @sergio-teruel
[UPD] Update website_sale_product_attribute_filter_visibility.pot
9ce0613
@oca-transbot @sergio-teruel
Update translation files
85a62a5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_product_attribute_filter_visibility
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_product_attribute_filter_visibility/
@cor9003 @sergio-teruel
[MIG] Migration to 12.0
7553bcc
@OCA-git-bot @sergio-teruel
[UPD] README.rst
51dd612
@oca-travis @sergio-teruel
[UPD] Update website_sale_product_attribute_filter_visibility.pot
9d53825
@oca-transbot @sergio-teruel
Update translation files
ba8fb79 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_attribute_filter_visibility
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_attribute_filter_visibility/
@OCA-git-bot @sergio-teruel
[UPD] README.rst
a7b99a0
@sergio-teruel
[MIG] website_sale_product_attribute_filter_visibility: Migration scr…
ccb3fb3 
…ipt to v12.0
@Tardo @sergio-teruel
[IMP] website_sale_product_attribute_filter_visibility: black, isort
7182a37
@sergio-teruel sergio-teruel force-pushed the 13.0-mig-website_sale_product_attribute_filter_visibility branch from 6e8240a to 5e95720 Compare March 16, 2020 10:00
@Tardo
Copy link
Member Author

Tardo commented Mar 30, 2020

ping @chienandalu

chienandalu
chienandalu approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests 👍

Some minor and non blocking remarks

website_sale_product_attribute_filter_visibility/README.rst Show resolved Hide resolved
website_sale_product_attribute_filter_visibility/__manifest__.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Tardo Tardo force-pushed the 13.0-mig-website_sale_product_attribute_filter_visibility branch from 5e95720 to 3a78849 Compare April 21, 2020 17:05
@Tardo
Copy link
Member Author

Tardo commented Apr 21, 2020

Changes done

@chienandalu
Copy link
Member

Thanks :)

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump

More information

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 23, 2020
Closed
22 tasks
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-334-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d5edffc into OCA:13.0 Apr 23, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4d27616. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Tardo @sergio-teruel @OCA-git-bot @chienandalu @pedrobaeza @oca-travis @oca-transbot @cor9003