Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] website_sale_hide_price: Migration to 12.0 #339

Merged
merged 13 commits into from
Feb 20, 2020

Conversation

maitaoriana
Copy link
Contributor

No description provided.

chienandalu and others added 12 commits February 19, 2020 11:29
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/fa/
Currently translated at 75.0% (3 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/de/
…event show prices in cart (OCA#244)

* Add to cart hidden if not website_show_price
* Hide quantity selector
* bump version and added contributor
Currently translated at 50.0% (2 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/it/
@maitaoriana
Copy link
Contributor Author

I opened another PR because I can't commit to branch @dbo-odoo PR #254 . Can they review this PR? Please @simahawk @sotolucas

@OCA-git-bot OCA-git-bot mentioned this pull request Feb 19, 2020
19 tasks
@simahawk simahawk added this to the 12.0 milestone Feb 19, 2020
@sotolucas
Copy link
Member

sotolucas commented Feb 19, 2020

👍 LGTM (functional and technical review were made).
@simahawk maybe a "Known Issues / Roadmap" section can be added to README and a point there regarding to add a feature to make this module compatible with Odoo's multi-website feature?

@simahawk
Copy link
Contributor

@sotolucas you still have to submit your review ;)
@maitaoriana would you mind to update the roadmap?

@maitaoriana
Copy link
Contributor Author

Done @simahawk @sotolucas

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-339-by-simahawk-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7ce2985 into OCA:12.0 Feb 20, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 24e8c0e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet