[IMP]8.0 product links migr

[fevxie]

[INIT] Initialization migrate product_links module to 8.0

[guewen]

s/Soruce/Source/

[guewen]

Thanks 👍

[pedrobaeza]

This version is incorrect. It should be 1.0. Odoo will add 8.0 itself at the beginning.

[coveralls]

Coverage increased (+0.91%) to 89.29% when pulling f234db9 on fevxie:8.0-product_links_migr into 13a941d on OCA:8.0.

[yvaucher]

@fevxie Your commits are not properly linked to you github account either you didn't configured git with an email or you need to add your email on your github account

[fevxie]

Hi @yvaucher, thanks for your reminder. I config my email according https://help.github.com/articles/setting-your-email-in-git/ using commands: git config --global && $GIT_COMMITTER_EMAIL && $GIT_AUTHOR_EMAIL, I din't get any information about how to update this pull request email? Do I need to update this?

Thanks

[yvaucher]

@fevxie As you pushed those commit without email you need to amend them.

You can do this using

git rebase -i origin/8.0

replace all pick by edit
save and quit -> :wq

Then it will pause for each commit. Do:

git commit --amend --author="Author Name <email@address.com>"
git rebase --continue

Then push those changes here, you will need to force push:

git push -f

Now you should see you avatar on commits of this PR

[coveralls]

Coverage increased (+1.48%) to 51.21% when pulling 9d5e1ca on fevxie:8.0-product_links_migr into 360dc14 on OCA:8.0.

[fevxie]

@yvaucher Thanks for your patient steps, Done.

[guewen]

Should be "Product Links" and the = line should be of the sale length (otherwise the rst parser raises an error)

[fevxie]

what do you mean "should be of the sale length" ? the same length with the sale module ?

[guewen]

This one is useless in v8 (see #40 (comment))

[guewen]

Thanks! 👍

[yvaucher]

@fevxie Thanks for the changes 👍

Will can merge once travis is happy