[ADD] website_sale_vat_required #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be on website project, doesn't it? |
eLBati
force-pushed
the
add_required_vat
branch
from
07f8de9
to
1b45277
Compare
eLBati
force-pushed
the
add_required_vat
branch
from
1b45277
to
ba25062
Compare
|
@pedrobaeza Isn't website project for CMS modules mainly? |
|
No, website it's for modules that modify front-end things, like this one. You have also selected website_sale prefix for this reason. Please move it, and take the ocassion to select a more specific icon than the cart icon (putting an overlayed VAT word for example). |
|
Ok @pedrobaeza , done with OCA/website#24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module extends checkout e-commerce form in order to force user to fill 'VAT number' field