[13.0][MIG] website_sale_vat_required: Migration to 13.0 #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestotejeda
force-pushed
the
13.0-mig-website_sale_vat_required
branch
from
f0fd225
to
860396e
Compare
HaraldPanten
approved these changes
Oct 3, 2020
victoralmau
suggested changes
Oct 7, 2020
ernestotejeda
force-pushed
the
13.0-mig-website_sale_vat_required
branch
from
860396e
to
3261952
Compare
|
Hi @ernestotejeda could you have a look at travis related comments? THX! |
ernestotejeda
force-pushed
the
13.0-mig-website_sale_vat_required
branch
from
3261952
to
8cdbc92
Compare
|
Please rebase |
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-12.0/e-commerce-12.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_vat_required/
ernestotejeda
force-pushed
the
13.0-mig-website_sale_vat_required
branch
from
8cdbc92
to
2110152
Compare
|
@pedrobaeza @HaraldPanten ready to review |
|
Functionally working fine. Tested on runbot |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 8fe9b54. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT25964