[13.0][MIG] website_sale_require_legal: Migration to 13.0 #443

ernestotejeda · 2020-10-07T17:42:28Z

chienandalu

Tours are failing

website_sale_require_legal/views/assets.xml

Tardo · 2020-10-13T13:27:44Z

website_sale_require_legal/views/assets.xml

+        <xpath expr=".">
+            <script
+                type="text/javascript"
+                src="/website_sale_require_legal/static/src/js/tour.js"


Move tour.js to a new location: /website_sale_require_legal/static/tests/tours/tour.js

ernestotejeda · 2020-10-13T16:43:05Z

@pedrobaeza , I have applied CSS to the label of the checkbox to be in red if it is not checked. I think that with that, we don't have to modify website_legal_page (OCA/website#782) so the translations of this module will not be affected.

pedrobaeza · 2020-10-13T18:26:06Z

Shouldn't the CSS be applied on parent module?

ernestotejeda · 2020-10-14T03:25:34Z

I don't think so, In this case the selector of the css rule is based on the input that is created in this module

sergio-teruel · 2020-10-15T13:40:35Z

Is needed this module??
You can customize this option in odoo core checkout step
https://github.com/odoo/odoo/blob/905fe5af69094051b9f7bf433a9c83cc0953fde1/addons/website_sale/views/templates.xml#L1489

ernestotejeda · 2020-10-15T14:57:26Z

Yes, maybe this module is not necessary. Ping @pedrobaeza . Confirm this to me to do the corresponding changes in OpenUpgrade

pedrobaeza · 2020-10-15T14:58:27Z

Please show me screenshots of the existing feature and the module to compare

ernestotejeda · 2020-10-15T15:07:43Z

This is how this module works:

sergio-teruel · 2020-10-19T06:09:48Z

I think that with the core function it's ok

chienandalu

The core function looks good, but we should check if metadata is still being registered (

e-commerce/website_sale_require_legal/controllers/main.py

Lines 37 to 51 in fdec6c1

    
           def _checkout_form_save(self, mode, checkout, all_values): 
        
               res = super()._checkout_form_save(mode, checkout, all_values) 
        
               if all_values.get("submitted") and all_values.get("accepted_legal_terms"): 
        
                   environ = request.httprequest.headers.environ 
        
                   metadata = "Website legal terms acceptance metadata: " 
        
                   metadata += "<br/>".join( 
        
                       "{}: {}".format(val, environ.get(val)) 
        
                       for val in ("REMOTE_ADDR", "HTTP_USER_AGENT", "HTTP_ACCEPT_LANGUAGE",) 
        
                   ) 
        
                   partner_id = request.env["res.partner"].browse(res) 
        
                   website_user = request.website.salesperson_id.id or SUPERUSER_ID 
        
                   partner_id.with_user(website_user).message_post( 
        
                       body=metadata, message_type="notification" 
        
                   ) 
        
               return res

) as it's a legal requirement in some countries.

sergio-teruel · 2020-10-19T14:36:04Z

@chienandalu What do you propose?

chienandalu · 2020-10-19T15:26:14Z

To check if it's covered. Otherwise, we should do it (maybe in other module)

ernestotejeda · 2020-10-19T16:28:37Z

@chienandalu , I have reviewed and as I have seen, with the Odoo core functionality, this metadata is not sent either when the address user form is modified or when the payment is done, no matter if the checkbox of the terms and terms is checked.

pedrobaeza · 2020-10-19T16:49:41Z

I think you haven't showed how standard works (or the video was for the standard?). And if so, how the other works? I want to compare? Anyway, that metadata should be saved, so this module can remain for at least that.

ernestotejeda · 2020-10-19T17:05:23Z

@pedrobaeza standard works: [13.0][MIG] website_sale_require_legal: Migration to 13.0 #443 (comment)
And this is how this module works: [13.0][MIG] website_sale_require_legal: Migration to 13.0 #443 (comment) , I just didn't show in the video that the metadata is recorded in the chatter of the partner associated with the user.

pedrobaeza · 2020-10-19T17:07:11Z

Ok, thanks. Then let's keep this module for recording that metadata.

ernestotejeda · 2020-10-19T18:57:23Z

@sergio-teruel @chienandalu @pedrobaeza Ready to review.

sergio-teruel

I have a doubt...
We are going to use the core check but recording the metadata... Is that so?

sergio-teruel · 2020-10-19T19:15:56Z

website_sale_require_legal/README.rst

+======================
+
+* Shopping terms and conditions are accepted only on user registration or
+  address edition. So if those terms change after the user signed up, a


With the new behavior, the checkbox is displayed in checkout step.

@sergio-teruel , the Odoo (core) option shows the check box always just before paying, but what this point of the readme refers to is to show that box only if the terms have changed (perhaps to be shown before paying as well). I think they are two different things. And it seems to me that to cover that point (if we needed), we must add the functionality in this module, because the odoo option is not very configurable since it is a template designed to be activated and deactivated by the UI.

What do you think?

pedrobaeza · 2020-11-11T15:29:12Z

@ernestotejeda please check this

ernestotejeda · 2020-11-17T16:44:00Z

@pedrobaeza @sergio-teruel @chienandalu
What are we going to do with this PR?

HaraldPanten · 2020-12-15T18:29:17Z

Hi,

Any news about this module? Finally we're going to keep it in OCA, right? @pedrobaeza

yajo · 2021-07-12T13:36:09Z

Last commit applies all that has been discussed and tests it. Also, rebased. Please review again. Thanks!

pedrobaeza · 2021-07-12T14:28:17Z

Travis is red

…cope This is what the module does now: - Add the posibility to configure legal terms acceptance requirement before saving a new partner. - Log that acceptance as a note in the partner. - Extend upstream's legal requirement before payment and log that acceptance as a note in the sale order. @Tecnativa TT25963

yajo · 2021-07-13T07:34:48Z

Thanks, it should be fixed now.

chienandalu

👍 Tested

pedrobaeza · 2021-07-15T16:10:09Z

/ocabot merge nobump

OCA-git-bot · 2021-07-15T16:10:17Z

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-443-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2021-07-15T17:14:30Z

Congratulations, your PR was merged at f8749df. Thanks a lot for contributing to OCA. ❤️

pedrobaeza requested review from Tardo and yajo October 7, 2020 17:44

ernestotejeda force-pushed the 13.0-mig-website_sale_require_legal branch from e0ef4d7 to 8cb6f9a Compare October 7, 2020 22:00

chienandalu suggested changes Oct 8, 2020

View reviewed changes

Tardo suggested changes Oct 13, 2020

View reviewed changes

website_sale_require_legal/views/assets.xml Outdated Show resolved Hide resolved

Tardo suggested changes Oct 13, 2020

View reviewed changes

ernestotejeda force-pushed the 13.0-mig-website_sale_require_legal branch from 8cb6f9a to 9f2d564 Compare October 13, 2020 16:33

ernestotejeda force-pushed the 13.0-mig-website_sale_require_legal branch 2 times, most recently from cc2f8a9 to fdec6c1 Compare October 14, 2020 03:30

chienandalu reviewed Oct 19, 2020

View reviewed changes

ernestotejeda force-pushed the 13.0-mig-website_sale_require_legal branch from fdec6c1 to af10f0d Compare October 19, 2020 17:11

sergio-teruel suggested changes Oct 19, 2020

View reviewed changes

OCA-git-bot and others added 7 commits July 12, 2021 14:34

[UPD] README.rst

5a6a714

[UPD] Update website_sale_require_legal.pot

83f0140

[FIX] website_sale_require_legal: Tour Test

ac8c56a

[UPD] README.rst

7f1defd

Added translation using Weblate (Finnish)

36aa5a2

[IMP] website_sale_require_legal: black, isort, prettier

935a50a

[MIG] website_sale_require_legal: Migration to 13.0

0dd4da5

yajo force-pushed the 13.0-mig-website_sale_require_legal branch from 857e039 to 8437ce8 Compare July 12, 2021 13:35

yajo approved these changes Jul 12, 2021

View reviewed changes

yajo force-pushed the 13.0-mig-website_sale_require_legal branch from 8437ce8 to 18f9a6e Compare July 13, 2021 07:33

yajo force-pushed the 13.0-mig-website_sale_require_legal branch from 18f9a6e to 6b9c2ba Compare July 13, 2021 07:33

yajo requested review from chienandalu, sergio-teruel, yajo and pedrobaeza and removed request for yajo July 13, 2021 09:12

chienandalu approved these changes Jul 13, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jul 15, 2021

pedrobaeza mentioned this pull request Jul 15, 2021

Migration to version 13.0 #304

Closed

22 tasks

OCA-git-bot merged commit 21bf8d4 into OCA:13.0 Jul 15, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 15, 2021

yajo deleted the 13.0-mig-website_sale_require_legal branch July 16, 2021 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] website_sale_require_legal: Migration to 13.0 #443

[13.0][MIG] website_sale_require_legal: Migration to 13.0 #443

ernestotejeda commented Oct 7, 2020

chienandalu left a comment

Tardo Oct 13, 2020

ernestotejeda commented Oct 13, 2020

pedrobaeza commented Oct 13, 2020

ernestotejeda commented Oct 14, 2020

sergio-teruel commented Oct 15, 2020

ernestotejeda commented Oct 15, 2020

pedrobaeza commented Oct 15, 2020

ernestotejeda commented Oct 15, 2020

sergio-teruel commented Oct 19, 2020

chienandalu left a comment

sergio-teruel commented Oct 19, 2020

chienandalu commented Oct 19, 2020

ernestotejeda commented Oct 19, 2020

pedrobaeza commented Oct 19, 2020

ernestotejeda commented Oct 19, 2020

pedrobaeza commented Oct 19, 2020

ernestotejeda commented Oct 19, 2020

sergio-teruel left a comment

sergio-teruel Oct 19, 2020

ernestotejeda Nov 12, 2020

ernestotejeda Nov 12, 2020

pedrobaeza commented Nov 11, 2020

ernestotejeda commented Nov 17, 2020

HaraldPanten commented Dec 15, 2020

yajo commented Jul 12, 2021

pedrobaeza commented Jul 12, 2021

yajo commented Jul 13, 2021

chienandalu left a comment

pedrobaeza commented Jul 15, 2021

OCA-git-bot commented Jul 15, 2021

OCA-git-bot commented Jul 15, 2021

	def _checkout_form_save(self, mode, checkout, all_values):
	res = super()._checkout_form_save(mode, checkout, all_values)
	if all_values.get("submitted") and all_values.get("accepted_legal_terms"):
	environ = request.httprequest.headers.environ
	metadata = "Website legal terms acceptance metadata: "
	metadata += "<br/>".join(
	"{}: {}".format(val, environ.get(val))
	for val in ("REMOTE_ADDR", "HTTP_USER_AGENT", "HTTP_ACCEPT_LANGUAGE",)
	)
	partner_id = request.env["res.partner"].browse(res)
	website_user = request.website.salesperson_id.id or SUPERUSER_ID
	partner_id.with_user(website_user).message_post(
	body=metadata, message_type="notification"
	)
	return res

[13.0][MIG] website_sale_require_legal: Migration to 13.0 #443

[13.0][MIG] website_sale_require_legal: Migration to 13.0 #443

Conversation

ernestotejeda commented Oct 7, 2020

chienandalu left a comment

Choose a reason for hiding this comment

Tardo Oct 13, 2020

Choose a reason for hiding this comment

ernestotejeda commented Oct 13, 2020

pedrobaeza commented Oct 13, 2020

ernestotejeda commented Oct 14, 2020

sergio-teruel commented Oct 15, 2020

ernestotejeda commented Oct 15, 2020

pedrobaeza commented Oct 15, 2020

ernestotejeda commented Oct 15, 2020

sergio-teruel commented Oct 19, 2020

chienandalu left a comment

Choose a reason for hiding this comment

sergio-teruel commented Oct 19, 2020

chienandalu commented Oct 19, 2020

ernestotejeda commented Oct 19, 2020

pedrobaeza commented Oct 19, 2020

ernestotejeda commented Oct 19, 2020

pedrobaeza commented Oct 19, 2020

ernestotejeda commented Oct 19, 2020

sergio-teruel left a comment

Choose a reason for hiding this comment

sergio-teruel Oct 19, 2020

Choose a reason for hiding this comment

ernestotejeda Nov 12, 2020

Choose a reason for hiding this comment

ernestotejeda Nov 12, 2020

Choose a reason for hiding this comment

pedrobaeza commented Nov 11, 2020

ernestotejeda commented Nov 17, 2020

HaraldPanten commented Dec 15, 2020

yajo commented Jul 12, 2021

pedrobaeza commented Jul 12, 2021

yajo commented Jul 13, 2021

chienandalu left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 15, 2021

OCA-git-bot commented Jul 15, 2021

OCA-git-bot commented Jul 15, 2021