Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] website_sale_hide_price: Migration to 13.0 #450

Merged
merged 20 commits into from
Dec 1, 2020
Merged

[MIG] website_sale_hide_price: Migration to 13.0 #450

merged 20 commits into from
Dec 1, 2020

Conversation

maitaoriana
Copy link
Contributor

No description provided.

chienandalu and others added 18 commits October 20, 2020 11:27
@chienandalu @maitaoriana
[10.0] website_sale_hide_price: New module
6ae9088
@oca-transbot @maitaoriana
OCA Transbot updated translations from Transifex
1e18c62
@AbrahamTrey @maitaoriana
[MIG] website_sale_hide_price: Migration to 11.0
25de353
@oca-travis @maitaoriana
[UPD] Update website_sale_hide_price.pot
b898634
@fshahy @maitaoriana
Translated using Weblate (Persian)
64388dd 
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/fa/
@maitaoriana
Translated using Weblate (German)
90c1628 
Currently translated at 75.0% (3 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/de/
@JuanjoA @maitaoriana
[FIX][11.0][website_sale_hide_price] Disable Add to cart option to pr…
446c179 
…event show prices in cart (OCA#244)

* Add to cart hidden if not website_show_price
* Hide quantity selector
* bump version and added contributor
@maitaoriana
[FIX] web_sale_hide_price: fix error with product comparison tool
6fbf269 
add original validation of the view
@paolovalier @maitaoriana
Translated using Weblate (Italian)
bedbf9f 
Currently translated at 50.0% (2 of 4 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/it/
@OCA-git-bot @maitaoriana
[ADD] icon.png
27ca385
@bouvyd @maitaoriana
[MIG] website_sale_hide_price: Migration to 12.0
61117be
@maitaoriana
[MIG] website_sale_hide_price: Migration to 12.0
c589971
@maitaoriana
[REF] website_sale_hide_price: known issues added to README
a893706
@oca-travis @maitaoriana
[UPD] Update website_sale_hide_price.pot
8b8949e
@oca-transbot @maitaoriana
Update translation files
5e226c7 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/
@AndreVolksdorf @maitaoriana
Translated using Weblate (German)
8f5d4e6 
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/de/
@sysadminmatmoz @maitaoriana
Translated using Weblate (Slovenian)
645d13e 
Currently translated at 100.0% (4 of 4 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/sl/
@maitaoriana
[IMP] website_sale_hide_price: black, isort, prettier
35bdd18
@pedrobaeza pedrobaeza added this to the 13.0 milestone Oct 20, 2020
@pedrobaeza pedrobaeza mentioned this pull request Oct 20, 2020
Closed
22 tasks
@maitaoriana maitaoriana force-pushed the 13.0-mig-website_sale_hide_price branch from 3fa47a9 to 2136bae Compare October 20, 2020 15:49
@maitaoriana
Copy link
Contributor Author

Hi @pedrobaeza, the migration is ready, please could you review it? Thanks

@pedrobaeza
Copy link
Member

I have added the PR to the migration issue, but I'm not a qualified reviewer.

tonygalmiche
tonygalmiche approved these changes Nov 8, 2020
View reviewed changes
Copy link
Sponsor

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : Functional review only with runbot

image

chienandalu
chienandalu approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the compare views still show the price
image

@pedrobaeza
Copy link
Member

@chienandalu then it's not an approval?

chienandalu
chienandalu suggested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry

@maitaoriana
Copy link
Contributor Author

@chienandalu Thanks by you review

I think that to hide the price on the comparator is not the responsibility of this module because it would need to depend on website_sale_comparison. Besides on v 12 this module doesn't hide the prices on the comparator. Video

To add this new feature would be good to create a new module that depends on this module and website_sale_comparison module. 

chienandalu
chienandalu approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-450-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit f52e1e3 into OCA:13.0 Dec 1, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9539f5d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonygalmiche tonygalmiche tonygalmiche approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet