[12.0][MIG] website_sale_order_type: Migration to 12.0 #454
Conversation
joao-p-marques
force-pushed
the
12.0-mig-website_sale_order_type
branch
from
cb536bc
to
280385a
Compare
joao-p-marques
force-pushed
the
12.0-mig-website_sale_order_type
branch
from
b86cad5
to
24d4a16
Compare
|
Please, check Travis |
Without this patch, it's easy that the tour fails randomly due to a timeout when generating the sales order report. These assets can take a long time, increasing when more addons are installed.
In an integrated database, this patch makes the test go from this log:
2020-11-06 10:34:53,941 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:34:53] "POST /payment/transfer/feedback HTTP/1.1" 302 - 730 4.368 11.800
To this one:
2020-11-06 10:32:55,517 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:32:55] "POST /payment/transfer/feedback HTTP/1.1" 302 - 479 2.906 5.771
That's about 50% the time.
In the same patch, I remove the `self.env` patch that was only needed for Odoo v11 and lower.
joao-p-marques
force-pushed
the
12.0-mig-website_sale_order_type
branch
from
24d4a16
to
a217009
Compare
|
Travis is green now @victoralmau Thank you 👍 |
| <template id="assets_frontend" inherit_id="website_sale.assets_frontend"> | ||
| <xpath expr="."> | ||
| <script type="text/javascript" | ||
| src="/website_sale_order_type/static/src/js/website_sale_order_type_tour.js"/> |
There was a problem hiding this comment.
Why is this regular data instead of demo one? Put also a note for being moved to assets_tests + data on v13.
There was a problem hiding this comment.
Thanks. Changes made! Was that what you meant?
There was a problem hiding this comment.
It's still loaded as data instead of demo. In manifest, put the XML in demo key and move the file to demo folder.
There was a problem hiding this comment.
I think it was already like that: https://github.com/OCA/e-commerce/pull/454/files#diff-c638094d29e2fd858515ae4b86befdf3258a8b235bfad3842845768b76d1519cR18-R20
Right?
There was a problem hiding this comment.
I just need to move it to the demo folder
There was a problem hiding this comment.
Change done @pedrobaeza
joao-p-marques
force-pushed
the
12.0-mig-website_sale_order_type
branch
from
a217009
to
8fde58f
Compare
With the old tour, timeout problems started to occur, even with 7830084 This partially reverts that, and instead uses a simpler tour to test the creation of the SO. TT26399
joao-p-marques
force-pushed
the
12.0-mig-website_sale_order_type
branch
from
8fde58f
to
ab6b97b
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
This PR has the |
|
Congratulations, your PR was merged at 31262c9. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa
TT26399
ping @pedrobaeza @rafaelbn