Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [MIG] website_sale_wishlist_keep: Migration to v13.0 #496

Merged
merged 8 commits into from
Feb 27, 2021

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT27485

Please @joao-p-marques @ernestotejeda review this

@CarlosRoca13 CarlosRoca13 changed the title [13.0] [MIG] website_sale_wishlist_keep: MIgration to v13.0 [13.0] [MIG] website_sale_wishlist_keep: Migration to v13.0 Feb 17, 2021
Copy link
Member

@ernestotejeda ernestotejeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review: 👍

Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

Just a small suggestion to the docs, but nothing blocking

Comment on lines 41 to 42
#. Active Customize > Keep items on wishlist
#. You can see the option checked allways that you go to the wishlist.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. Active Customize > Keep items on wishlist
#. You can see the option checked allways that you go to the wishlist.
#. You can see the "Add product to my cart but keep it in my wishlist" option checked by default

Copy link
Contributor Author

@CarlosRoca13 CarlosRoca13 Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first step that you suggest to delete is needed, but probably someone do it before you

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-496-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza pedrobaeza added this to the 13.0 milestone Feb 27, 2021
@pedrobaeza pedrobaeza mentioned this pull request Feb 27, 2021
22 tasks
@OCA-git-bot OCA-git-bot merged commit 694d50a into OCA:13.0 Feb 27, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 881985b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants