[13.0][MIG] website_sale_tax_toggle: Migration #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-12.0/e-commerce-12.0-website_sale_tax_toggle Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_tax_toggle/
This tour was not effective because: - Steps did not have proper wait conditions. - That made them run fast without actually testing the desired effect. - That left many remaining requests that could made tests to fail randomly, as you can see in OCA#420 (comment). Now it's shorter but more effective: - It skips going to `/shop` at the start because it starts already there. - It moves tour code to demo data. - It adds proper checks to each trigger, to make sure it doesn't run before checking the result is OK. @Tecnativa TT24410
…2x_alt_price @Tecnativa TT24410
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_tax_toggle Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_tax_toggle/fr/
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_tax_toggle Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_tax_toggle/ca/
sergio-teruel
force-pushed
the
13.0-mig-website_sale_tax_toggle
branch
3 times, most recently
from
b1027df
to
0bd1c13
Compare
sergio-teruel
changed the title
CarlosRoca13
approved these changes
Feb 22, 2021
| <!-- Copyright 2020 Tecnativa - Jairo Llopis | ||
| License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). --> | ||
| <data> | ||
| <template id="assets_frontend_demo" inherit_id="website.assets_frontend"> |
There was a problem hiding this comment.
Suggested change
| <template id="assets_frontend_demo" inherit_id="website.assets_frontend"> | |
| <template id="assets_tests_demo" inherit_id="website.assets_tests"> |
On v13 exists the view assets_test. This assets are loaded just when testing, so you can place the file on templates and inherit from this view on data. Not need to place the assets on demo anymore
| odoo.define("website_sale_tax_toggle.tax_toggle_button", function(require) { | ||
| "use strict"; | ||
|
|
||
| var sAnimation = require("website.content.snippets.animation"); |
There was a problem hiding this comment.
Suggested change
| var sAnimation = require("website.content.snippets.animation"); | |
| const sAnimation = require("website.content.snippets.animation"); |
| }, | ||
| _onPublishBtnClick: function(ev) { | ||
| ev.preventDefault(); | ||
| var $data = $(ev.currentTarget).parents(".js_tax_toggle_management:first"); |
There was a problem hiding this comment.
Suggested change
| var $data = $(ev.currentTarget).parents(".js_tax_toggle_management:first"); | |
| const $data = $(ev.currentTarget).parents(".js_tax_toggle_management:first"); |
Comment on lines
7
to
8
| var tour = require("web_tour.tour"); | ||
| var base = require("web_editor.base"); |
There was a problem hiding this comment.
Suggested change
| var tour = require("web_tour.tour"); | |
| var base = require("web_editor.base"); | |
| const tour = require("web_tour.tour"); | |
| const base = require("web_editor.base"); |
| // Notice that it's important targeting the price as `span .oe_currency_value` | ||
| // or `.oe_price .oe_currency_value` to make sure this test is compatible | ||
| // with website_sale_b2x_alt_price module in this same repo. | ||
| var steps = [ |
There was a problem hiding this comment.
Suggested change
| var steps = [ | |
| const steps = [ |
|
This PR has the |
sergio-teruel
force-pushed
the
13.0-mig-website_sale_tax_toggle
branch
from
0bd1c13
to
2d358d5
Compare
|
@CarlosRoca13 Changes done!!! |
CarlosRoca13
suggested changes
Feb 22, 2021
| <!-- Copyright 2020 Tecnativa - Jairo Llopis | ||
| License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). --> | ||
| <data> | ||
| <template id="assets_tests_demo" inherit_id="website.assets_tests_demo"> |
There was a problem hiding this comment.
Suggested change
| <template id="assets_tests_demo" inherit_id="website.assets_tests_demo"> | |
| <template id="assets_tests_demo" inherit_id="website.assets_tests"> |
sergio-teruel
force-pushed
the
13.0-mig-website_sale_tax_toggle
branch
from
2d358d5
to
ec83f17
Compare
|
@CarlosRoca13 Sorry!! Changes done!! |
CarlosRoca13
approved these changes
Mar 3, 2021
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 4dce6f3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT27484
@CarlosRoca13 @chienandalu Can you review?