-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0] [MIG] website_sale_stock_available_display: Migration to v13.0 #504
[13.0] [MIG] website_sale_stock_available_display: Migration to v13.0 #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Tested on runbot...
QWeb | ||
); | ||
load_xml.then(function() { | ||
$(".oe_website_sale") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
#. Go to *'Website > Products > Products'*. | ||
#. Set *Show inventory on website and allow sales if not enough stock* in | ||
inventory availability field. | ||
#. You can set a custom message that appears when available stock is less than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tardo it is in the eCommerce tag, after the "Availability field".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review 👍
Just some small suggestions
import setuptools | ||
|
||
setuptools.setup( | ||
setup_requires=['setuptools-odoo'], | ||
odoo_addon=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes should go in the [IMP]
commit
"data": [ | ||
"views/assets.xml", | ||
"templates/assets.xml", | ||
"views/product_template_views.xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage | ||
===== | ||
|
||
#. Go to *'Website > Products > Products'*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#. Go to *'Website > Products > Products'*. | |
#. Go to *'Website > Products > Products'* and select a Product. |
#. Set *Show inventory on website and allow sales if not enough stock* in | ||
inventory availability field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#. Set *Show inventory on website and allow sales if not enough stock* in | |
inventory availability field. | |
#. Set *Show inventory on website and allow sales if not enough stock* in | |
inventory availability field in the "eCommerce" tab. |
2c40b8f
to
ceb741b
Compare
@joao-p-marques changes done and @Tardo I removed the unnecesary code on js |
ceb741b
to
c572b75
Compare
* [11.0][NEW] website_sale_stock_available_display: New module * [11.0][NEW] website_sale_stock_available_display: New module * [11.0][IMP] website_sale_stock_available_display: Re-use custom_message field to allow to display custom information when the product stock is less than 0 units * [11.0][IMP] website_sale_stock_available_display: Fix test
… attrs in view to avoid crash with other modules
…ive units to display danger style message
…le quantities with a context key to allow display quantities computed by other modules
…ive units to display danger style message
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/de/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/es/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/fr/
Currently translated at 36.3% (4 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/nl/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/ca/
c572b75
to
fdaa0b8
Compare
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at ba1377f. Thanks a lot for contributing to OCA. ❤️ |
Removing a state change in the purchase order that now is not needed anymore.
cc @Tecnativa TT26959
please @sergio-teruel @joao-p-marques review this