Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [MIG] website_sale_stock_available_display: Migration to v13.0 #504

Merged

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT26959

please @sergio-teruel @joao-p-marques review this

Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Tested on runbot...

QWeb
);
load_xml.then(function() {
$(".oe_website_sale")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

#. Go to *'Website > Products > Products'*.
#. Set *Show inventory on website and allow sales if not enough stock* in
inventory availability field.
#. You can set a custom message that appears when available stock is less than
Copy link
Member

@Tardo Tardo Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tardo it is in the eCommerce tag, after the "Availability field".

Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

Just some small suggestions

Comment on lines +1 to +6
import setuptools

setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes should go in the [IMP] commit

"data": [
"views/assets.xml",
"templates/assets.xml",
"views/product_template_views.xml",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage
=====

#. Go to *'Website > Products > Products'*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. Go to *'Website > Products > Products'*.
#. Go to *'Website > Products > Products'* and select a Product.

Comment on lines 43 to 44
#. Set *Show inventory on website and allow sales if not enough stock* in
inventory availability field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. Set *Show inventory on website and allow sales if not enough stock* in
inventory availability field.
#. Set *Show inventory on website and allow sales if not enough stock* in
inventory availability field in the "eCommerce" tab.

@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-website_sale_stock_available_display branch from 2c40b8f to ceb741b Compare February 23, 2021 11:55
@CarlosRoca13
Copy link
Contributor Author

@joao-p-marques changes done and @Tardo I removed the unnecesary code on js

@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-website_sale_stock_available_display branch from ceb741b to c572b75 Compare February 23, 2021 12:54
sergio-teruel and others added 17 commits February 26, 2021 09:58
* [11.0][NEW] website_sale_stock_available_display: New module

* [11.0][NEW] website_sale_stock_available_display: New module

* [11.0][IMP] website_sale_stock_available_display: Re-use custom_message field to allow to display custom information when the product stock is less than 0 units

* [11.0][IMP] website_sale_stock_available_display: Fix test
… attrs in view to avoid crash with other modules
…le quantities with a context key to allow display quantities computed by other modules
Currently translated at 100.0% (11 of 11 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/de/
Currently translated at 100.0% (11 of 11 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/es/
Currently translated at 100.0% (11 of 11 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/fr/
Currently translated at 36.3% (4 of 11 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/nl/
Currently translated at 100.0% (11 of 11 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_stock_available_display
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_stock_available_display/ca/
@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-website_sale_stock_available_display branch from c572b75 to fdaa0b8 Compare February 26, 2021 08:58
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza pedrobaeza added this to the 13.0 milestone Feb 27, 2021
@pedrobaeza pedrobaeza mentioned this pull request Feb 27, 2021
22 tasks
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-504-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0c0f547 into OCA:13.0 Feb 27, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba1377f. Thanks a lot for contributing to OCA. ❤️

volodymyr-dehtiarenko pushed a commit to volodymyr-dehtiarenko/e-commerce that referenced this pull request Jan 26, 2022
Removing a state change in the purchase order that now is not needed anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet