-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0] [MIG] website_snippet_product_category: Migration to v13 #526
[13.0] [MIG] website_snippet_product_category: Migration to v13 #526
Conversation
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/es/
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/fr/
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/fr/
Currently translated at 22.2% (2 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/nl/
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/ca/
I set it in WIP because I need some help with next situation:
I tried to put this attribute to all columns but I can't achieve the expected behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review.
Just 2 minor issues, otherwise looks good 👍
@@ -0,0 +1,17 @@ | |||
// Copyright 2020 Tecnativa - Alexandre Díaz | |||
// License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl). | |||
odoo.define("website_snippet_carousel_product.snippet_options", function(require) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we define here this snippet options related to another module, shouldn't we add it as a dependency?
type="object" | ||
icon="fa-globe" | ||
> | ||
<field name="is_published" widget="website_button" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
sAnimation.registry.js_product_category = sAnimation.Class.extend({ | ||
selector: ".js_product_category", | ||
disabledInEditableMode: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check how the widget behaves in v12? It really doesn't let you edit anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I test it, but if I don't use this key we can't see the preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see 👍
2b0c5de
to
9a3835c
Compare
@joao-p-marques changes done |
@CarlosRoca13 is this still WIP? |
9a3835c
to
9530d24
Compare
No, it isn't @pedrobaeza |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at c80a81d. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT26961
please @Tardo @joao-p-marques review this.