Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [MIG] website_snippet_product_category: Migration to v13 #526

Merged

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT26961

please @Tardo @joao-p-marques review this.

Tardo and others added 13 commits April 12, 2021 17:14
Currently translated at 100.0% (9 of 9 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/es/
Currently translated at 100.0% (9 of 9 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/fr/
Currently translated at 100.0% (9 of 9 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/fr/
Currently translated at 22.2% (2 of 9 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/nl/
Currently translated at 100.0% (9 of 9 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_snippet_product_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_snippet_product_category/ca/
@CarlosRoca13
Copy link
Contributor Author

I set it in WIP because I need some help with next situation:

  • When we are at editable mode, the columns can be edited even though the block has the attribute contenteditable="False"

I tried to put this attribute to all columns but I can't achieve the expected behavior

Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review.
Just 2 minor issues, otherwise looks good 👍

@@ -0,0 +1,17 @@
// Copyright 2020 Tecnativa - Alexandre Díaz
// License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl).
odoo.define("website_snippet_carousel_product.snippet_options", function(require) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we define here this snippet options related to another module, shouldn't we add it as a dependency?

type="object"
icon="fa-globe"
>
<field name="is_published" widget="website_button" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see this button correctly in the runbot:
image


sAnimation.registry.js_product_category = sAnimation.Class.extend({
selector: ".js_product_category",
disabledInEditableMode: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check how the widget behaves in v12? It really doesn't let you edit anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I test it, but if I don't use this key we can't see the preview

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see 👍

@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-website_snippet_product_category branch from 2b0c5de to 9a3835c Compare April 14, 2021 15:03
@CarlosRoca13
Copy link
Contributor Author

@joao-p-marques changes done

@pedrobaeza pedrobaeza added this to the 13.0 milestone Apr 15, 2021
@pedrobaeza
Copy link
Member

@CarlosRoca13 is this still WIP?

@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-website_snippet_product_category branch from 9a3835c to 9530d24 Compare April 15, 2021 08:06
@CarlosRoca13 CarlosRoca13 changed the title [WIP] [13.0] [MIG] website_snippet_product_category: Migration to v13 [13.0] [MIG] website_snippet_product_category: Migration to v13 Apr 15, 2021
@CarlosRoca13
Copy link
Contributor Author

No, it isn't @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza pedrobaeza mentioned this pull request Apr 15, 2021
22 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-526-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0ec0564 into OCA:13.0 Apr 15, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c80a81d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants