Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] website_sale_resource_booking: Migration to 13.0 #583

Merged

Conversation

yajo
Copy link
Member

@yajo yajo commented Nov 8, 2021

@victoralmau victoralmau force-pushed the 13.0-mig-website_sale_resource_booking branch 2 times, most recently from 5b9cb2d to 2e1f0eb Compare February 2, 2022 08:02
Jairo Llopis and others added 4 commits February 2, 2022 09:04
This module extends the functionality of ``sale_resource_booking`` to support
the eCommerce use case and to allow your visitors to buy products that produce
a resource booking, and pre-book them before buying.

You can also set a timeout for those pre-bookings to expire if unpaid.

@Tecnativa TT28202
Before this patch, when a resource.booking was canceled due to being expired, reactivating it would immediately cancel it again when cron ran again.

@Tecnativa TT29651

[UPD] Update website_sale_resource_booking.pot

[UPD] README.rst
…er is accessible

If someone introduces a different email address for the resource
booking, a partner with such email is searched and if not found,
created, which is correct in theory.

But the core method used for that goal (`find_or_create` in
`res.partner`) is not taking multi-company into account, searching
partners only matching by mail, and creating them in the default
company.

Due to this, this commits changes the resource booking partner
population code to perform the search and creation controlling the
involved company.

TT33276
@victoralmau victoralmau force-pushed the 13.0-mig-website_sale_resource_booking branch from 2e1f0eb to 7b202be Compare February 2, 2022 08:09
@victoralmau victoralmau force-pushed the 13.0-mig-website_sale_resource_booking branch from 7b202be to bf7fda1 Compare February 2, 2022 08:11
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok.
It's ready to review.
Ping @chienandalu @pedrobaeza

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍 Thanks :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza marked this pull request as ready for review February 3, 2022 20:38
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza
Copy link
Member

/ocabot migration website_sale_resource_booking

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-583-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 13.0 milestone Feb 3, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 3, 2022
22 tasks
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 89bb414. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 087303b into OCA:13.0 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants