Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] website_sale_attribute_filter_form_submit: Migration to 13.0 #587

Merged
merged 3 commits into from
Dec 10, 2021
Merged

[MIG] website_sale_attribute_filter_form_submit: Migration to 13.0 #587

merged 3 commits into from
Dec 10, 2021

Conversation

chienandalu
Copy link
Member

cc @Tecnativa TT30550

please review @victoralmau @ernestotejeda

ping @miguels73

victoralmau
victoralmau approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK.
Please, squash administrative commits to reduce commits.

@chienandalu chienandalu force-pushed the 13.0-mig-website_sale_attribute_filter_form_submit branch from 66438e5 to 3deefc9 Compare November 12, 2021 09:57
ernestotejeda
ernestotejeda suggested changes Nov 16, 2021
View reviewed changes
Copy link
Member

@ernestotejeda ernestotejeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests OK.

website_sale_attribute_filter_form_submit/readme/CONFIGURE.rst Show resolved Hide resolved
website_sale_attribute_filter_form_submit/static/src/js/website_sale.js Outdated Show resolved Hide resolved
@chienandalu chienandalu force-pushed the 13.0-mig-website_sale_attribute_filter_form_submit branch from 3deefc9 to 4e28f9f Compare December 10, 2021 09:18
@chienandalu
Copy link
Member Author

Thanks @ernestotejeda changes done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

/ocabot migration website_sale_attribute_filter_form_submit

@OCA-git-bot OCA-git-bot added this to the 13.0 milestone Dec 10, 2021
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-587-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 10, 2021
Closed
22 tasks
@OCA-git-bot OCA-git-bot merged commit 4538e3c into OCA:13.0 Dec 10, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ef04a6f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@ernestotejeda ernestotejeda ernestotejeda approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chienandalu @OCA-git-bot @pedrobaeza @victoralmau @ernestotejeda