Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Namepsacing] functions with node_name should not hard code namespace #137

Closed
blaggacao opened this issue Sep 30, 2019 · 1 comment
Closed
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@blaggacao
Copy link

def _ubl_add_party(self, partner, company, node_name, parent_node, ns, version='2.1')
hardcodes cbc here: party = etree.SubElement(parent_node, ns['cac'] + node_name)

instead, pass prefixed node_name and carry the nsmap of #131

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 6, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

1 participant