[8.0] Wrong line price with UBL Import due to wrong calculated unit price

[bosd]

I have imported a UBL Invoice of my fuel pass supplier.
It has multiple lines, besides fuel it also contains some parking costs.
I set the Method of Invoice Line to ”Multi Line, No Product”.
The expected result is that in Odoo I have the same invoice line price as in the UBL file.

Current behavior:
The price does not match UBL file.
The first invoice line should be €71,41 instead of €71,01.

Input code for the first line:
cac:InvoiceLine
cbc:ID1</cbc:ID>
<cbc:InvoicedQuantity unitCode="LTR">70.31</cbc:InvoicedQuantity>
<cbc:LineExtensionAmount currencyID="EUR">71.41</cbc:LineExtensionAmount>
cac:OrderLineReference
cbc:LineID1</cbc:LineID>
</cac:OrderLineReference>
cac:TaxTotal
<cbc:TaxAmount currencyID="EUR">15.00</cbc:TaxAmount>
cac:TaxSubtotal
<cbc:TaxableAmount currencyID="EUR">71.41</cbc:TaxableAmount>
<cbc:TaxAmount currencyID="EUR">15.00</cbc:TaxAmount>
cac:TaxCategory
<cbc:ID schemeID="UNCL5305" schemeAgencyID="6">S</cbc:ID>
cbc:Percent21.00</cbc:Percent>
cac:TaxScheme
<cbc:ID schemeID="UN/ECE 5153" schemeAgencyID="6">VAT</cbc:ID>
</cac:TaxScheme>
</cac:TaxCategory>
</cac:TaxSubtotal>
</cac:TaxTotal>
cac:Item
cbc:DescriptionDiesel</cbc:Description>
cbc:NameDiesel</cbc:Name>
</cac:Item>
</cac:InvoiceLine>

complete input
UBLInvoice.0006311117.xml.txt

[alexis-via]

@bosd : Would you agree if we add your UBL invoice to the automated test suite, so that when the bug is fixed (I plan to work on it this month) we are sure it doesn't "come back" ? Do you want to anonymise some stuff in the XML before adding it to the test suite ?

[alexis-via]

This is what happens for the 1st line: it reads:
<cbc:InvoicedQuantity unitCode="LTR">70.31</cbc:InvoicedQuantity>
<cbc:LineExtensionAmount currencyID="EUR">71.41</cbc:LineExtensionAmount>

So it writes in invoice line:
qty = 70.31
price unit = 71.41 / 70.31 = 1.01564
As the decimal precision for price unit is 2 by default, it writes price unit = 1.01 (should be 1.02...)
So the subtotal is 1.01 * 70.31 = 71.01

I see 3 solutions for this:
a) higher decimal precision for price unit => I exclude this solution because it impacts all invoices, including customer invoices
b) when this case happens, write:
qty = 1
price unit = price subtotal = 71.41
We loose the information about the exact qty...
c) keep the current behavior and add a line "Adjustement" which has the difference between the total untaxed computed by Odoo and the total untaxed of the invoice.

For the moment, I prefer option c (even if, in this particular case for gas, loosing the info of the qty is not important, so option b would be fine). @bosd what do you think ?

[bosd]

@alexis-via
Yes you may use the UBL file in the test suite. It is already annonimzed. As the adress is on sesamestreet :)

Well, maybe it is in my lack of knowledge of odoo. But I was expecting to have the quantity and price unit to be dynamic. Though that will be more something into the core of odoo.

As a sollution I also prefer option C . So the total quantity of the product will still be visible.

[alexis-via]

I implemented option c) on v10 tonight and I'm pretty happy with the result. I have 2 levels of adjustments:

1. when, for a particular line, the price_subtotal is different between odoo and the XML file -> il create an adjustment line related to that line (same properties, same taxes, etc..)
2. after those per-line adjustement, if there is still a difference between the amount_untaxed in Odoo and the monetary summation in the XML, I add a global adjustment line that has no tax and no product.

I added the invoice of this bug report to the automated test suite. I'll push the code to github when @bosd will confirm he agrees on that.