[10.0][FIX]Fix supplier search for variant #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbaden
reviewed
May 20, 2019
base_ubl/models/ubl.py
Outdated
| @@ -344,7 +344,8 @@ def _ubl_add_item( | |||
| if seller: | |||
| sellers = self.env['product.supplierinfo'].search([ | |||
| ('name', '=', seller.id), | |||
| ('product_tmpl_id', '=', product.product_tmpl_id.id)]) | |||
| ('product_tmpl_id', '=', product.product_tmpl_id.id), | |||
There was a problem hiding this comment.
is there even a need for the template id if you use the variant id?
|
@tbaden But while investigating I amended this PR since we need to search on product_id when variants are used and product_id when variants are not used. |
BenjaHe
approved these changes
May 22, 2019
|
Please use this method instead: |
|
@pedrobaeza |
astirpe
pushed a commit
to onesteinbv/edi
that referenced
this pull request
Dec 13, 2019
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
3 tasks
astirpe
pushed a commit
to onesteinbv/edi
that referenced
this pull request
Dec 13, 2019
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
3 tasks
alexis-via
pushed a commit
that referenced
this pull request
Dec 31, 2019
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
astirpe
pushed a commit
to onesteinbv/edi
that referenced
this pull request
Feb 28, 2020
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
alexis-via
pushed a commit
that referenced
this pull request
Mar 3, 2020
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
2 tasks
phuctranfxvn
pushed a commit
to trobz/edi
that referenced
this pull request
Jan 3, 2021
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
fshah-initos
pushed a commit
to initOS/edi
that referenced
this pull request
May 5, 2021
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
simahawk
pushed a commit
to simahawk/edi
that referenced
this pull request
Jul 9, 2021
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
tbanevicius
pushed a commit
to tbanevicius/edi
that referenced
this pull request
Mar 22, 2022
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
ghost
pushed a commit
to gbrito/edi
that referenced
this pull request
Feb 14, 2023
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
aisopuro
pushed a commit
to avoinsystems/edi
that referenced
this pull request
Feb 27, 2023
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
ghost
pushed a commit
to gbrito/edi
that referenced
this pull request
Mar 28, 2023
* [10.0][FIX]Fix supplier search for variant * fix flake8 * use _select_seller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.