Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] account_invoice_ubl_email_attachment #109

Closed
wants to merge 5 commits into from
Closed

[12.0][MIG] account_invoice_ubl_email_attachment #109

wants to merge 5 commits into from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented May 29, 2019

No description provided.

tbaden
tbaden approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM

@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 1, 2019
Closed
18 tasks
@mgielissen
Copy link

Merge?

@astirpe
Copy link
Member Author

astirpe commented Jul 10, 2019

@mgielissen did you test this V12 module?

@mgielissen
Copy link

Yes, I'm using it already.

@astirpe
Copy link
Member Author

astirpe commented Jul 10, 2019

@mgielissen ok, thanks! Would you please go to "Files changed" -> "Review changes", and then "Approve"?

@pedrobaeza pedrobaeza added this to the 12.0 milestone Aug 21, 2019
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 12.0-ocabot-merge-pr-109-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot added a commit that referenced this pull request Aug 21, 2019
@OCA-git-bot
Merge PR #109 into 12.0
a81a2aa 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a81a2aa. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@astirpe astirpe deleted the 12_mig_account_invoice_ubl_email_attachment branch August 21, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@mgielissen mgielissen mgielissen approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@astirpe @mgielissen @pedrobaeza @OCA-git-bot @tbaden @oca-travis