[10.0][FIX] base_ubl: PartyName node is not mandatory in xsd so it should not be mandatory in code either.

[SimoRubi]

I have edited one of the test files to allow testing this change, please advise me if I should test it in any other way.

[astirpe]

@SimoRubi I would prefer to keep that test unchanged.
Would be nice if you can create a new extra test for this specific case and perhaps checking that also other non-mandatory fields are correctly handled.
Anyway your PR looks good to me.

[SimoRubi]

Hi, thanks for the review!
I have created a separated file for tests as you suggested, and noticed this untested flow:

edi/sale_order_import/wizard/sale_order_import.py

Lines 291 to 305 in 046d68d

	if existing_quotations:
	default_sale_id = False
	if len(existing_quotations) == 1:
	default_sale_id = existing_quotations[0].id
	self.write({
	'commercial_partner_id': commercial_partner.id,
	'partner_shipping_id': partner_shipping_id,
	'state': 'update',
	'sale_id': default_sale_id,
	'doc_type': parsed_order.get('doc_type'),
	})
	action = self.env['ir.actions.act_window'].for_xml_id(
	'sale_order_import', 'sale_order_import_action')
	action['res_id'] = self.id
	return action

So I have refactored a little the test class to allow testing this flow and ease adding future new tests.

[SimoRubi]

@OCA/edi-maintainers can someone take a look? Thanks

[astirpe]

Looks good! Thanks!

[SimoRubi]

@OCA/edi-maintainers can this be merged or should I change something? Thanks

[tafaRU]

LGTM Thanks!

[SimoneVagile]

Good for me, thanks!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[bealdav]

Please @astirpe maybe you can merge ?