Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][8.0] Merge EDI incubator #4

Merged
merged 169 commits into from Oct 4, 2016
Merged

Conversation

adrienpeiffer
Copy link
Contributor

Fix for multi-company (field on res.partner should be a property)
Small usability improvements
Add help message inside wizard
Block if invoice already exists
Add YAML test for invoice update
Fallback on matching on partner name
Code cleanup
Finish the TODO list !
When Odoo propose to update an existing invoice, filter on the relevant invoice type
@pedrobaeza
Copy link
Member

Maybe it's possible to reduce a bit the number of commits squashing some of them together?

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 82.061% when pulling 69e06bf on edi-sprint:8.0-edi-incubator into 79621a4 on OCA:8.0.

@alexis-via
Copy link
Contributor

👍 Great ! Travis is green. Thank you VERY MUCH to @adrienpeiffer for the hard work with git/travis/...

@rousseldenis
Copy link
Sponsor

👍 Great work @alexis-via!

@gva-acsone
Copy link

👍 (functional test)

@luanaduarte
Copy link

👍 Functional test

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 82.061% when pulling 637d73d on edi-sprint:8.0-edi-incubator into 79621a4 on OCA:8.0.

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 82.061% when pulling 637d73d on edi-sprint:8.0-edi-incubator into 79621a4 on OCA:8.0.

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 82.061% when pulling 637d73d on edi-sprint:8.0-edi-incubator into 79621a4 on OCA:8.0.

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 82.061% when pulling 637d73d on edi-sprint:8.0-edi-incubator into 79621a4 on OCA:8.0.

@alexis-via
Copy link
Contributor

We have a problem: this branch doesn't contain the changes I made this morning: commit 2f319c2a74bd6ae39f8d5e51f7cdf8348ba78385:

Add support for extraction + matching on website

Add mimetype text/xml in addition to application/xml
FIX issue in account_invoice_import_invoice2data

So it seems that someone made a push -f on the branch.
And the commit of @houssine78 is not pep8 compliant (this change was already included in my commit of this morning but pep8 compliant)

@alexis-via
Copy link
Contributor

OK, I remember now: before going for lunch, I tried to push my commit but it failed with an error "ERROR: Sorry, but @edi-sprint has blocked access to SSH keys created by some third-party applications. Your key was created before GitHub tracked keys created by applications, so we need your help." and I forgot to investigate the issue after lunch. So I pushed again my commit (I had to adapt it because @houssine78 made the same fix in the meantime... but with pep8 errors ; and also the fix in invoice2data that was in my initial commit was already there...).
I solve the github's question on SSH key and managed to push my commit this time ! We should now be OK.

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 81.908% when pulling 8a1dfb2 on edi-sprint:8.0-edi-incubator into 79621a4 on OCA:8.0.

@alexis-via alexis-via merged commit 8765a7a into OCA:8.0 Oct 4, 2016
@houssine78
Copy link
Sponsor

Hi @alexis-via sorry for the pep8 error I get problems to commit cause didn't have sufficient access then I got a conflict so I've restarted the changes without checking the pep8.

yankinmax pushed a commit to camptocamp/edi that referenced this pull request May 24, 2021
[FIX] account_invoice_import: fix external_id for Vendor bills action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants