[13.0][IMP] base_ubl: hook to add the AdditionalAccountID ubl field

[FerranCforgeFlow]

Added a _ubl_get_additional_reference method to be able to add the AdditionalAccountID ubl field in the _ubl_add_supplier_party

[OCA-git-bot]

Hi @FerranCforgeFlow! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

[FerranCforgeFlow]

@bealdav could you check?

[RaulOForgeFlow]

👍

[FerranCforgeFlow]

@bealdav could you please check?

[albariera]

LGTM 👍

[bealdav]

Ok, thanks
I ask myself if there is no other way to add new misc nodes dynamically (method with parameter).
It seems there many conditional additions in the code now.
But if we need to do smth, it could be in an other PR I suppose

[etobella]

Wouldn't be easier to return the node customer_party_root and anyone can do its specific changes if needed?? (For example for the partner reference or the additional Account Id)

[FerranCforgeFlow]

What you are saying is actually a more solid option. I opted for the alternative of adding generic methods that people can inherit if wanted.

[FerranCforgeFlow]

Could it be merged?

[etobella]

Might be possible to apply the proposed change? This way it is easier and all this kind of hooks are unnecessary.

[FerranCforgeFlow]

Taking a look at the code, it is better to return the nodes as you said to allow customization. I have already changed it in both, customer and supplier methods. Thanks for the advice!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[etobella]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-429-by-etobella-bump-minor, awaiting test results.

[OCA-git-bot]

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-429-by-etobella-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[LoisRForgeFlow]

@etobella could you try again the merge?

[bealdav]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-429-by-bealdav-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at fa2a9af. Thanks a lot for contributing to OCA. ❤️