Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] base_business_document_import #492

Closed

Conversation

alexis-via and others added 30 commits December 8, 2021 17:20
…voice dict, cleaner organisation)

Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD)
Now support PDF with embedded UBL XML file
Enable unittests on account_invoice_import_ubl
More absolute xpath in account_invoice_import_ubl instead of relative xpath

WARNING: these are big changes, I may have broken a few details
Adapt module account_invoice_import_ubl to use the new base_ubl module
Small fixes
Better generation of address block in UBL (make it coherent with the datamodel of Odoo)
Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party
Add parsing of zip in UBL party (will be used in the future for delivery partner match)
Use country code and state code to match partners
UBL: Add delivery terms and line item UBL XML block generation
UBL: add parsing of delivery block
Add unitests in base_business_document_import
Small code enhancements/simplifications
Code cleanup/minor changes
Rename key 'quantity' to 'qty' in all parsing dicts['lines']
Add common methods compare_lines() and post_create_or_update()
Make sure price_unit is always untaxed in UBL XML files
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
[FIX] LINT

Use try/except when importing external libs
Remove self.ensure_one() that has nothing to do in an api.model method
Rename __openerp__.py to __manifest__.py and set installable to False
Add match for accounts and journals
Improve match for journals and accounts
Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl
… module

Fix spelling mistake and other remarks on README by Tarteo
…o v10.0

base_business_document_import: Add support for the creation of res.bank
Add support for insertion of title in error messages
Add method to create SO in sale.order.import accessible via JSON-RPC
OCA-git-bot and others added 16 commits December 8, 2021 17:20
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-14.0/edi-14.0-base_business_document_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-base_business_document_import/
Currently translated at 97.4% (38 of 39 strings)

Translation: edi-14.0/edi-14.0-base_business_document_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-base_business_document_import/fr_FR/
Currently translated at 56.4% (22 of 39 strings)

Translation: edi-14.0/edi-14.0-base_business_document_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-base_business_document_import/nl/
Currently translated at 94.8% (37 of 39 strings)

Translation: edi-14.0/edi-14.0-base_business_document_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-base_business_document_import/nl/
Currently translated at 94.8% (37 of 39 strings)

Translation: edi-14.0/edi-14.0-base_business_document_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-base_business_document_import/fr/
Reduce _match_partner complexity
@koenloodts koenloodts mentioned this pull request Dec 8, 2021
35 tasks
@koenloodts koenloodts changed the title 15.0 mig base business document import [15.0][MIG] base_business_document_import Dec 8, 2021
@simahawk
Copy link
Contributor

Dependences are merged, you can clean test-req.
Recommendation for next time:

  1. link deps in the description (as done now)
  2. put the test-req change in a separated commit to make it prominent (eg: TMP add test-requirements.txt)

@simahawk
Copy link
Contributor

/ocabot migration base_business_document_import

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 25, 2022
@tbanevicius
Copy link

Hi @alexis-via . Can this MR be merged to 15.0 version?

@tbanevicius
Copy link

Hi @pedrobaeza is there any way this module could be merged as it was approved?

@pedrobaeza
Copy link
Member

This branch has conflicts and it doesn't have 2 approvals

@@ -0,0 +1,3 @@
git+https://github.com/OCA/community-data-files@refs/pull/122/head#subdirectory=setup/account_tax_unece
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you MUST cleanup this before merging

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any possibility for someone else to clean it? Because I've noticed that @koenloodts is inactive.

Copy link
Contributor

@simahawk simahawk Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbanevicius feel free to do it in a new PR 😉

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk created new PR #564 , cleaned test-requirements file. But noticed new checks come up regarding coverage. How is here target 0.00%?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet