Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] sale_order_import #60

Merged
merged 16 commits into from
Oct 31, 2018
Merged

[11.0][MIG] sale_order_import #60

merged 16 commits into from
Oct 31, 2018

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented May 17, 2018

No description provided.

@pedrobaeza pedrobaeza added this to the 11.0 milestone May 17, 2018
@pedrobaeza pedrobaeza mentioned this pull request May 17, 2018
Closed
27 tasks
@tarteo tarteo mentioned this pull request Jun 20, 2018
Merged
1 task
@astirpe
Copy link
Member

astirpe commented Jul 9, 2018 •
edited
Loading

@tarteo can you add sale-workflow and server-tools in the oca_dependencies.txt ? It should fix the travis error

@tarteo
Copy link
Member Author

tarteo commented Oct 9, 2018

@alexis-via Can you please review this :).

astirpe
astirpe requested changes Oct 9, 2018
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cherry-pick the latest commits from V10 ?
https://github.com/OCA/edi/commits/10.0/sale_order_import

@astirpe astirpe mentioned this pull request Oct 11, 2018
Closed
11 tasks
@astirpe
Copy link
Member

astirpe commented Oct 12, 2018

@tarteo I cherry-picked the latest commits from V10.0, rebased the branch and squashed a bit the commits. I hope is ok for you.

@coveralls
Copy link

coveralls commented Oct 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 55.715% when pulling 6feb6335c25a2d32bd2b478043baaebd8b0f0ad0 on tarteo:11.0-mig-sale_order_import into 6bbb7a3 on OCA:11.0.

astirpe
astirpe approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage will increase when #61 will be merged

@astirpe
Copy link
Member

astirpe commented Oct 17, 2018

@tarteo could you resolve the conflict on oca_dependencies.txt ?

PatrickMallee
PatrickMallee approved these changes Oct 30, 2018
View reviewed changes
Copy link

@PatrickMallee PatrickMallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@pedrobaeza
Copy link
Member

Some squashing would be good before merging.

@tarteo tarteo force-pushed the 11.0-mig-sale_order_import branch 2 times, most recently from ca81bf9 to 83e7b34 Compare October 31, 2018 09:46
@alexis-via @tarteo
Initial check-in of module sale_order_import, sale_stock_order_import…
ae7fc4c 
…, sale_order_import_ubl, sale_order_import_csv, sale_order_ubl, sale_commercial_partner
alexis-via and others added 11 commits October 31, 2018 11:06
@alexis-via @tarteo
Add 2 README.rst
059412a 
Add another README.
@alexis-via @tarteo
FIX Don't use _inherit = ['business.document.import']
3eac215 
because we want to have access to the code of the modules that inherit business.document.import
@adrienpeiffer @tarteo
[IMP] handle the case where the xml file is generated with mime type
292d380 
'text/xml'
@alexis-via @tarteo
Add support for extraction + matching on website
c2541bd 
PEP8 fix
@tarteo
8.0 Add support for partner bank matching on invoice update (OCA#6)
16e22b3 
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
@oca-transbot @tarteo
OCA Transbot updated translations from Transifex
c23ce4e
@alexis-via @tarteo
Prepare v10 branch
ec4ac7e 
Rename __openerp__.py to __manifest__.py and set installable to False
@alexis-via @tarteo
Continue port of modules for v10.0, in particular sale_order_import_*…
547eee6 
… module

Fix spelling mistake and other remarks on README by Tarteo
@alexis-via @tarteo
Port account_invoice_import_factur-x and account_invoice_import_ubl t…
55293b2 
…o v10.0

base_business_document_import: Add support for the creation of res.bank
@alexis-via @tarteo
Port purchase_order_import* to v10.0
5c24a48 
Add ubl invoice generation option in accounting config page
@alexis-via @tarteo
FIX crash when pivot format had a 'note' key (and no attachment)
c684a03 
Add method to create SO in sale.order.import accessible via JSON-RPC
oca-transbot and others added 4 commits October 31, 2018 11:07
@oca-transbot @tarteo
OCA Transbot updated translations from Transifex
b60c9fe
@tarteo
[11.0][MIG] sale_order_import: Migration + add tests
d0f33e8 
Add readme fragments
@alexis-via @tarteo
Fix import of sale order with price_source='pricelist' when pricelist…
6f9bcb6 
… has visible discounts

Code improvements in sale_order_import
Add unit tests in sale_order_import
Use display_name instead of name_get()[0][1]

Fix travis
@alexis-via @tarteo
Check the VAT number of the destination partner, to make sure the bus…
c83586e 
…iness document is imported in the right company
@tarteo
Copy link
Member Author

tarteo commented Oct 31, 2018 •
edited
Loading

@pedrobaeza The rebase is done. I couldn't squash a lot of commits, but it's reduced to 16.

@pedrobaeza pedrobaeza merged commit c64c89b into OCA:11.0 Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astirpe astirpe astirpe approved these changes

@PatrickMallee PatrickMallee PatrickMallee approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tarteo @astirpe @coveralls @pedrobaeza @PatrickMallee @alexis-via @adrienpeiffer @oca-transbot