Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] - check that customer vat match with user current company #68

Conversation

sbejaoui
Copy link

This check prevent users with multi-company access to import invoices other than their current company

This check prevent users with multi-company access to import invoices other than their current company
@oca-clabot
Copy link

Hey @sbejaoui, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@sbidoul
Copy link
Member

sbidoul commented Sep 12, 2018

@sbejaoui's contributions are now covered by the ACSONE ECLA

@sbidoul
Copy link
Member

sbidoul commented Sep 12, 2018

@sbejaoui it looks like your change makes travis red. Can you check?

@oca-clabot
Copy link

Hey @sbejaoui,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage increased (+0.04%) to 78.732% when pulling e99abed on sbejaoui:10.0-account_invoice_import_ubl_multi-company into a6cad43 on OCA:10.0.

@sbejaoui sbejaoui force-pushed the 10.0-account_invoice_import_ubl_multi-company branch from b432dff to e99abed Compare September 12, 2018 16:53
@alexis-via
Copy link
Contributor

The check is done in account_invoice_import on that line of code : https://github.com/OCA/edi/blob/10.0/account_invoice_import/wizard/account_invoice_import.py#L465
And the 'company' key in the pivot dict is implemented in account_invoice_import_ubl.
So it already checks that the invoice is imported in the right company.

@alexis-via alexis-via closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants