[14.0] edi: generate/send chain jobs + add identity exact match based on checksum #796
Conversation
|
Hi @etobella, |
simahawk
force-pushed
the
14-edi-fmwk-imp-jobs
branch
2 times, most recently
from
2a56439
to
4437f44
Compare
|
Indenty key does not work fine w/ job deps. We'll need this OCA/queue#546 |
simahawk
force-pushed
the
14-edi-fmwk-imp-jobs
branch
from
4437f44
to
91e7abf
Compare
The recommended way to execute actions on records is to call `action_exchange_*` on
simahawk
force-pushed
the
14-edi-fmwk-imp-jobs
branch
from
91e7abf
to
e9c1ae8
Compare
simahawk
changed the title
simahawk
changed the title
simahawk
changed the title
Instead of waiting for the cron to pass again and send the file chain the 2 jobs so that it gets sent right after generation.
* catch OSError * add debug log
Prevents having duplicated jobs for the same record as far as possible.
simahawk
force-pushed
the
14-edi-fmwk-imp-jobs
branch
from
1601216
to
fc0780a
Compare
Try to send out the file as fast as possible once the content is ready.
|
@etobella @HviorForgeFlow if you could pass by... 🙏 |
| hasher = identity_exact_hasher(job_) | ||
| # Include files checksum | ||
| hasher.update( | ||
| str(sorted(job_.recordset.mapped("exchange_filechecksum"))).encode("utf-8") |
There was a problem hiding this comment.
Why do yo need to add the file checksum? The function already contains ID of the exchange record and function 🤔
There was a problem hiding this comment.
Because is the only to way to know if the file is the same.
If by error you try to schedule another job you won't get duplicated jobs unless the content of the file is the same.
In most cases, if you rely only on the cron to process files you'll have the filter done by the check methods that will skip records not in the rate state or not w/ the right values to be generated/sent/received/processed.
However, if you force those checks and try to schedule a job for the a record whereas the file didn't change you shouldn't be able to.
There was a problem hiding this comment.
It might come handy also to compare files w/o reading the whole file (eg: to check if you received the same file twice).
There was a problem hiding this comment.
What will happen if the file is not generated?
|
This PR has the |
|
@etobella good for you or you seen any possible regression on your side? |
|
I don't see any major regressions from my side. 🤔 I tested with other OCA reports and everything works fine |
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 0a8ae3f. Thanks a lot for contributing to OCA. ❤️ |
|
@simahawk I migrated Just a question, could we change it to use WDYT? |
As long OSError are part of retryable exceptions and HTTPError inherits from OSSError we are catching the new exception * PR introducing that change: OCA#796 * HTTPError implementation: https://github.com/python/cpython/blob/3.12/Lib/urllib/error.py
As long OSError are part of retryable exceptions and HTTPError inherits from OSSError we are catching the new exception * PR introducing that change: OCA#796 * HTTPError implementation: https://github.com/python/cpython/blob/3.12/Lib/urllib/error.py
As long OSError are part of retryable exceptions and HTTPError inherits from OSSError we are catching the new exception * PR introducing that change: OCA#796 * HTTPError implementation: https://github.com/python/cpython/blob/3.12/Lib/urllib/error.py
Depends on:
See atomic commits for details.
Would be nice to use job chain for input too. Not a blocker tho.