[MIG] account_e-invoice_generate: Migration to 12.0 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… embedding in PDF between account_invoice_factur-x and account_invoice_ubl
Enable delivery block in UBL
|
Can you please see Travis problem and squash your migration commits into one (as they are not very meaningful)? |
|
Please rebase to fix the travis |
joshuajan
force-pushed
the
12.0-mig-account_e-invoice_generate
branch
from
8628328
to
68c7ae4
Compare
joshuajan
changed the title
|
Dear all, I have rebase and make all change into one commit. |
pedrobaeza
requested changes
Jan 14, 2019
There was a problem hiding this comment.
It would be great that you use the README by fragments system: https://github.com/OCA/maintainer-tools/#readme-generator
|
In fact, README by fragment is already used. You have to update that fragments instead for contributors part, and run the utility (or let the bot to run it after the merge, but at least the first step). |
joshuajan
force-pushed
the
12.0-mig-account_e-invoice_generate
branch
from
68c7ae4
to
0412841
Compare
|
Dear @pedrobaeza Thanks for your reply. I have update fragments. |
pedrobaeza
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.