Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] purchase_order_ubl + [ADD] purchase_stock_ubl #99

Merged
merged 20 commits into from
Aug 4, 2020

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Apr 2, 2019

No description provided.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 2, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 2, 2019
18 tasks
@astirpe
Copy link
Member Author

astirpe commented Apr 2, 2019

Since in V12 the module purchase does not depend anymore on stock, I'm going to split this module in two:

  • purchase_order_ubl
  • purchase_stock_ubl (auto installable, depends on purchase_order_ubl and purchase_stock)

@astirpe astirpe changed the title [12.0][MIG] purchase_order_ubl [12.0][MIG] purchase_order_ubl + [ADD] purchase_stock_ubl Apr 2, 2019
@astirpe astirpe force-pushed the 12_mig_purchase_order_ubl branch 2 times, most recently from 66c638b to 3802c47 Compare April 2, 2019 19:23
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cvinh
Copy link

cvinh commented Apr 25, 2020

This PR has to be updated because @alexis-via improved the reporting engine here 919275e
I fixed it here : onesteinbv#1

@astirpe
Copy link
Member Author

astirpe commented Apr 29, 2020

Thank you @cvinh !

alexis-via and others added 15 commits April 30, 2020 08:25
…ort_ubl and purchase_order_ubl

Move XSD files to base_ubl, to avoid duplication of UBL XSD files.
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
Prepare v10 branch

Rename __openerp__.py to __manifest__.py and set installable to False

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_zugferd to account_invoice_factur-x

Rename account_invoice_import_zugferd to account_invoice_import_factur-x
Add module to support py3o reporting engine:

Continue port of modules for v10.0, in particular sale_order_import_* module

Fix spelling mistake and other remarks on README by Tarteo

Disable get_pdf() in all tests because it doesn't work in Travis

[10.0] restore get_pdf() in tests (OCA#31)

* sale_order_ubl + purchase_order_ubl: restore get_pdf() in tests using HttpCase

* Restore get_pdf() in tests of account_invoice_factur-x and account_invoice_ubl modules

* Update oca_dependencies.txt
…ort_ubl and purchase_order_ubl

Move XSD files to base_ubl, to avoid duplication of UBL XSD files.
alexis-via and others added 2 commits April 30, 2020 08:32
Prepare v10 branch

Rename __openerp__.py to __manifest__.py and set installable to False

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_zugferd to account_invoice_factur-x

Rename account_invoice_import_zugferd to account_invoice_import_factur-x
Add module to support py3o reporting engine:

Continue port of modules for v10.0, in particular sale_order_import_* module

Fix spelling mistake and other remarks on README by Tarteo

Disable get_pdf() in all tests because it doesn't work in Travis

[10.0] restore get_pdf() in tests (OCA#31)

* sale_order_ubl + purchase_order_ubl: restore get_pdf() in tests using HttpCase

* Restore get_pdf() in tests of account_invoice_factur-x and account_invoice_ubl modules

* Update oca_dependencies.txt
Copy link
Sponsor

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just installed this module locally on my computer.
With demo data from Odoo 12.
The PDF on a price request works correctly (state = draft).
But the PDF on an order (state = purchase) does not work and I have this error

The UBL XML file is not valid against the official XML Schema Definition. The XML file and the full error have been written in the server logs. Here is the error, which may give you an idea on the cause of the problem : Element '{urn:oasis:names:specification:ubl:schema:xsd:CommonBasicComponents-2}IssueDate': '2020-05-03 00:00:00' is not a valid value of the atomic type 'xs:date'., line 5.

@astirpe astirpe force-pushed the 12_mig_purchase_order_ubl branch from ee44949 to 888e715 Compare May 4, 2020 09:14
@astirpe
Copy link
Member Author

astirpe commented May 4, 2020

@tonygalmiche thank you! Should be fixed now.

Copy link
Sponsor

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed on my computer
I tested with price requests and orders
I opened all PDF with 'Master PDF Editor' to see the XML file as an attachment
everything is OK
Thank you

@cvinh
Copy link

cvinh commented May 6, 2020

Cc @LuceEasyPme

Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx !

@astirpe
Copy link
Member Author

astirpe commented Aug 4, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-99-by-astirpe-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7435174 into OCA:12.0 Aug 4, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5ed6ea6. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 12_mig_purchase_order_ubl branch August 4, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet