[11.0][MIG] website_event_excerpt_img #100
Conversation
* Better layout for website events. Add event priority to display them as half or full row on website. * Simplify dramatically removing options. All or nothing now. This rewrites completely the event index layout, but it was impossible to get the desired effect without that due to core design, so I simplified everything. * Display metadata, show description below image in normal events. * Update module name as changed in last module version. * Avoid broken paginator layout when event number is odd. * Use event's timezone. (#57) Without this patch, the event's start and end dates (and times) will be inaccurate.
| @@ -1,6 +1,6 @@ | |||
| @charset "UTF-8"; | |||
| /* Copyright 2016 Tecnativa - Jairo Llopis | |||
| * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). */ | |||
| * License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). */ | |||
There was a problem hiding this comment.
Delete the file and include directly the sass file
There was a problem hiding this comment.
Does Odoo converts also sass files?
|
@yajo Can you please check again. Thanks in advance. |
oca_dependencies
Outdated
| @@ -0,0 +1,2 @@ | |||
| server-tools | |||
There was a problem hiding this comment.
Should the file be named oca_dependencies.txt?
|
https://travis-ci.org/OCA/event/jobs/404777684#L990 (Could not execute command 'sass') @yajo can you help me with travis error? I don't have any experience using sass in Odoo. |
|
That's a problem in travis itself, since it should have sass. I think you have to add some environment variable I cannot remember, such as |
|
Yes, is it WEBSITE_REPO="1" |
|
@yajo squashed them 👍 |
|
Now tests are failing 😕 |
[MIG] Images [IMP] Include sass file directly [ADD] oca_dependencies [ADD] oca_dependencies [ADD] Converted sass file to less [FIX] Close comment [FIX] Less file
|
@chienandalu Fixed it! 😄 |
There was a problem hiding this comment.
Great @tarteo Tested in runbot 👍
You could split the README into parts following the last OCA guidelines: https://github.com/OCA/maintainer-tools/tree/master/template/module/readme
|
Let's merge it as is and we let the README split for later. |
Depends on