[11.0][MIG] website_event_filter_selector #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can use selectors above the event list in the website, instead of the left column that there is right now. Store user customizations in separate template. Acknowledge that you cannot hide only the date filter. Remove search button; search on selection change. Fix bug where date did not match what was being filtered. [FIX][8.0][website_event_filter_selector] Do not die without types or countries This basically fixes #44 and a similar bug detected that would happen when no countries were found. It just adds a `t-if` to avoid possible failures, [borrowing the idea from core `website_event` module](https://github.com/odoo/odoo/blob/8.0/addons/website_event/views/website_event.xml#L167). [8.0][IMP][website_event_filter_selector] Add city filter for events. Since this includes new logic, it adds also a template for left-column filters. With this patch, you can now filter events depending on their cities, not only on their countries. This also includes some modifications that will make filters occupy always a full bootstrap row, no matter if there are 1, 2, 3 or 4 filters, to avoid ugly layouts.
[IMP] website_event_filter_selector: Spanish translation [IMP] website_event_filter_selector: German translation [FIX] website_event_filter_selector: Fix date selection [FIX] website_event_filter_selector: Fix city count [FIX] website_event_filter_selector: Don't lose context with new obj
Relicensed to LGPL, new JS API. Add test. Fix errors found with it. Go 100% coverage. Support online events. [FIX][website_event_filter_selector] Fix Travis build Builds failed on 2017-03-31 because the tour was expecting to see USA event starting in this month, but next day was another month. Well, in short, this fix makes the tour work on any day.
Includes update to use new tours api. Patch event counts when a city is searched.
|
Can you please check runbot status and maybe use new README fragments approach? |
|
@pedrobaeza Runbot seems to be working fine, I don't understand. Ah yes, I'll check the new template for the fragmented approach! |
|
There are 2 warnings in runbot: |
pedrobaeza
approved these changes
May 31, 2018
yajo
approved these changes
Jun 4, 2018
yajo
requested changes
Jun 4, 2018
There was a problem hiding this comment.
Code is ✔️
Functional test reveals that the usage of variable selection_filters_amount in partial views is not working as expected. All filters should be in the same row, as in previous versions, but they occupy 1 row each:
Maybe there's a better way to do that with Less directly. Keep in mind this addon came from v8, where there was no core Less support.
|
@yajo Didn't know it. But I took a look and apparently it produced classes like
|
|
Ah ok, it must be something new from P3. Could you please squash migration commits to merge? Thanks. |
[IMP] Use new README approach [IMP] Removed the use of @Class [FIX] Column classes
|
@yajo Squashed the mig commits |
yajo
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.