Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] crm_lead_to_event_registration: Migration to 11.0 #117

Merged

Conversation

cristinamartinrod
Copy link
Member

No description provided.

pedrobaeza and others added 3 commits September 11, 2018 14:17
* [ADD] crm_lead_to_event_registration

====================================
Register a lead directly in an event
====================================

This module allows to register a lead directly in an event when converting
this lead into a partner, so that you can save several steps.

Usage
=====

Go to any lead in *Sales > Sales > Leads*, and click on the button "Convert
to Opportunity".

In the resulting screen, if the conversion action is "Convert to opportunity"
and you have selected a related partner (a new or an existing one), you will
have a section called "Event registration".

In that section, you can select an event, and when you click on
"Create opportunity", the partner will be registered automatically in the
event.

* [IMP] crm_lead_to_event_registration: Track state changes

* [IMP] crm_lead_to_event_registration: Adapt to latest company changes
- Updated views
- Updated Readme
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cristinamartinrod !

  • Review Travis tests
  • Add .DS_Store to your .gitignore

crm_lead_to_event_registration/README.rst Show resolved Hide resolved
@chienandalu
Copy link
Member

Otherwise runbot ok 👍

@rafaelbn rafaelbn added this to the 11.0 milestone Sep 12, 2018
@pedrobaeza
Copy link
Member

@cristinamartinrod and what about the other comments?

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

"license": "AGPL-3",
"author": "Tecnativa, "
"Odoo Community Association (OCA)",
"website": "https://www.tecnativa.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristinamartinrod IMHO Replace URL as per this

crm_lead_to_event_registration/README.rst Show resolved Hide resolved
crm_lead_to_event_registration/models/crm_lead.py Outdated Show resolved Hide resolved
<field name="model">crm.lead</field>
<field name="inherit_id" ref="crm.crm_case_form_view_leads"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='referred']" position="after">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristinamartinrod Direct use field

<field name="model">crm.lead</field>
<field name="inherit_id" ref="crm.crm_case_form_view_oppor"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='source_id']" position="after">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@oca-clabot
Copy link

Hey @cristinamartinrod, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • Cris Martín (no github login found)

Appreciation of efforts,
OCA CLAbot

@cristinamartinrod
Copy link
Member Author

Done! Can you review please? @chienandalu @nikul-serpentcs

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash all the migration commits together

crm_lead_to_event_registration/models/crm_lead.py Outdated Show resolved Hide resolved
crm_lead_to_event_registration/models/crm_lead.py Outdated Show resolved Hide resolved
crm_lead_to_event_registration/readme/CREDITS.rst Outdated Show resolved Hide resolved
@cristinamartinrod cristinamartinrod force-pushed the 11.0-mig-crm_lead_to_event_registration branch from 56f2a34 to 8543092 Compare October 15, 2018 07:45
@cristinamartinrod cristinamartinrod force-pushed the 11.0-mig-crm_lead_to_event_registration branch from 8543092 to 0d836a0 Compare October 15, 2018 08:23
@pedrobaeza pedrobaeza merged commit a5bd3e1 into OCA:11.0 Oct 15, 2018
@pedrobaeza pedrobaeza deleted the 11.0-mig-crm_lead_to_event_registration branch October 15, 2018 08:54
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 28, 2018
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants