-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] crm_lead_to_event_registration: Migration to 11.0 #117
[11.0][MIG] crm_lead_to_event_registration: Migration to 11.0 #117
Conversation
* [ADD] crm_lead_to_event_registration ==================================== Register a lead directly in an event ==================================== This module allows to register a lead directly in an event when converting this lead into a partner, so that you can save several steps. Usage ===== Go to any lead in *Sales > Sales > Leads*, and click on the button "Convert to Opportunity". In the resulting screen, if the conversion action is "Convert to opportunity" and you have selected a related partner (a new or an existing one), you will have a section called "Event registration". In that section, you can select an event, and when you click on "Create opportunity", the partner will be registered automatically in the event. * [IMP] crm_lead_to_event_registration: Track state changes * [IMP] crm_lead_to_event_registration: Adapt to latest company changes
- Updated views - Updated Readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cristinamartinrod !
- Review Travis tests
- Add
.DS_Store
to your.gitignore
Otherwise runbot ok 👍 |
@cristinamartinrod and what about the other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve Code
"license": "AGPL-3", | ||
"author": "Tecnativa, " | ||
"Odoo Community Association (OCA)", | ||
"website": "https://www.tecnativa.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristinamartinrod IMHO Replace URL as per this
<field name="model">crm.lead</field> | ||
<field name="inherit_id" ref="crm.crm_case_form_view_leads"/> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//field[@name='referred']" position="after"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristinamartinrod Direct use field
<field name="model">crm.lead</field> | ||
<field name="inherit_id" ref="crm.crm_case_form_view_oppor"/> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//field[@name='source_id']" position="after"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Hey @cristinamartinrod, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Done! Can you review please? @chienandalu @nikul-serpentcs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash all the migration commits together
56f2a34
to
8543092
Compare
8543092
to
0d836a0
Compare
No description provided.