[8.0][website_event_sale_legal] Legal terms per event

[yajo]

Legal terms per event

This module was written to extend the functionality of online event ticket
sales to support setting legal terms that attendees will accept when ordering
their registrations.

Legal terms can be set by event and/or by ticket.

CC @rafaelbn.

[yajo]

Ah sorry, this will fail until OCA/e-commerce#72 is merged.

[dreispt]

I'll mark this as WIP, while the dependency is not merged.

[eLBati]

Restarted travis build

[rafaelbn]

OCA/e-commerce#72 is merged, we can rebuild and change label to need fixing.

[yajo]

Remove WIP please.

[yajo]

Ah sorry please add again WIP, because this now requires OCA/e-commerce#78, which is an improvement over OCA/e-commerce#72.

[yajo]

Rebased, squashed, this is now ready to review because OCA/e-commerce#78 is merged.

[yajo]

Runbot fails because it is not installing oca_dependencies.txt. Shouldn't this be automatic?

[pedrobaeza]

No, that automation is not yet available. I have to add the dependencies by hand. Done and launch a rebuild.

[yajo]

Thanks! I clicked force rebuild.

[rafaelbn]

Still fails

  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3135345-12-bacc07/openerp/addons/base/module/module.py", line 393, in state_update
    raise orm.except_orm(_('Error'), _("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
except_orm: ('Error', u"You try to install module 'website_event_sale_legal' that depends on module 'website_sale_product_legal'.\nBut the latter module is not available in your system.")

[pedrobaeza]

Isn't that module in website repo?

[rafaelbn]

Not, is in e-commerce: https://github.com/OCA/e-commerce/

[pedrobaeza]

OK, it should be now

[rafaelbn]

www.antiun.com

[rafaelbn]

Please @yajo review comments and rebase for testing. Runbot fails and dependencies are merged

[yajo]

Rebased.

[rafaelbn]

Please add a configuration menu in Marketing " Legal terms for products" as you have it in Sales

Tested 👍 really nice, thanks!

Check travis!

[yajo]

Now you have a menu of legal terms inside Marketing > Configuration, and you can assign a legal term to many events at once.

About Travis, it seems a timeout, let's see if this time it works. Another option is that it is a failure in the tour test. If so, I'll fix it later, when I learn how to do it in OCA/e-commerce#71.

[janetrp]

Tested in runbot 👍

[yajo]

Travis should pass now.

[pedrobaeza]

I'm afraid not. Add configuration on .travis.yml to support wkhtmltopdf like this one:

• https://github.com/OCA/account-financial-reporting/blob/8.0/.travis.yml#L11
• https://github.com/OCA/account-financial-reporting/blob/8.0/.travis.yml#L26-L28

[yajo]

Thanks for that @pedrobaeza! Done.

[pedrobaeza]

👍 Green!

[rafaelbn]

@yajo please related to this module in v8 and GDPR take a look in v10: https://drive.google.com/file/d/15jsI5L6Frm8jOCOFoP_ai8J4yU3WEhZw/view?usp=sharing

Should be something like

Ping @chienandalu