[11.0][MIG] event_registration_cancel_reason: Migration to 11.0 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
============================================= Reasons for event registrations cancellations ============================================= This module allows to add a predefined reason why a registration for an event is cancelled. Configuration ============= Go to *Marketing > Configuration > Events > Registrations cancel reasons* for setting the possible reasons you want to handle. You can also set if a reason is only available for certain events or, if you leave it empty, for all. Usage ===== Go to *Marketing > Events > Events*, enter into the details or any of the events, and press the red circle button in the right part of any of the registrations. A new screen will appear asking you to enter the reason why the registration is cancelled. You will get also the same screen when pressing the button *Cancel registration* from the details view of a registration in *Marketing > Events > Registrations*. On this object, you can group by the cancel reason in the list, calendar or graph view.
* Move cancel_reason_id so it's visible to non-technical user * Overide do_draft method to set cancel_reason_id to False when Set to unconfirmed
…ing and fix tests. Fix OCA#35. When an event had no type, it was not getting in the mapping because of the way Odoo generates recordsets.
- Updated README - Updated views - Updated tests - Improve tests to achieve full test coverage
chienandalu
suggested changes
Sep 25, 2018
| # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html | ||
|
|
||
| from . import models | ||
| from . import wizard | ||
| from . import wizard |
pedrobaeza
requested changes
Sep 25, 2018
There was a problem hiding this comment.
You have these flake8 errors:
event_registration_cancel_reason/__manifest__.py:2:44: W291 trailing whitespace
event_registration_cancel_reason/models/event_registration.py:2:44: W291 trailing whitespace
event_registration_cancel_reason/tests/test_event_registration_cancel_reason.py:2:44: W291 trailing whitespace
event_registration_cancel_reason/wizard/event_registration_cancel_log_reason.py:2:44: W291 trailing whitespace
| # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html | ||
|
|
||
| from . import models | ||
| from . import wizard | ||
| from . import wizard |
| # Copyright 2016 Antiun Ingeniería S.L. | ||
| # Copyright 2016 Pedro M. Baeza <pedro.baeza@tecnativa.com> | ||
| # Copyright 2016 Tecnativa - Pedro M. Baeza |
There was a problem hiding this comment.
Remove copyright on __init__ (it's a bad old habit).
| ~~~~~~~ | ||
|
|
||
| * Tecnativa | ||
| * Antiun Ingeniería S.L. |
There was a problem hiding this comment.
No need to put this file. Authors are put automatically by the script. This file is intended for extra credits, like funders or so.
| # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html | ||
|
|
||
| { | ||
| "name": "Reasons for event registrations cancellations", | ||
| "version": "9.0.1.0.0", | ||
| "version": "11.0.1.0.0", | ||
| "license": "AGPL-3", | ||
| "author": "Antiun Ingeniería S.L., " |
There was a problem hiding this comment.
Remove this company. It's Rafa's old one, and the IP now has been passed to Tecnativa.
| # Copyright 2016 Antiun Ingeniería S.L. | ||
| # Copyright 2016 Pedro M. Baeza <pedro.baeza@serviciosbaeza.com> | ||
| # Copyright 2016 Tecnativa - Pedro M. Baeza |
pedrobaeza
approved these changes
Sep 25, 2018
|
@chienandalu you can re-review |
chienandalu
reviewed
Sep 25, 2018
There was a problem hiding this comment.
@cristinamartinrod You didn't regenerate the README from the new parts.
|
@chienandalu she is not able to do it right now with Mac. We are dealing with that, and I'll do it when squashing, but meanwhile, let out that requirement. |
pedrobaeza
force-pushed
the
11.0-mig-event_registration_cancel_reason
branch
from
137ddae
to
c5d8147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.