[11.0] [MIG] event_session #127

ntsirintanis · 2018-11-28T11:07:52Z

Migrated here is only the logic of 10.0 event.session module that defines sessions for events. Aspects like separate session registration, seat availability per session, mail notifications per session that were included in event.session 10.0 are now omitted, because they are not really essential for defining a session, i.e., these are extra functionalities beyond the scope of this module.
More logic (or reintroduction of omitted aspects) may be implemented separately via a different module that depends on event.session 11.0. @NL66278 @lfreeke

* Rename 'date' to 'date_begin' for being homogeneous with event fields * Split tests * Remove 'start_time' and 'end_time' as no needed * Convert hours to UTC for avoiding timezone issues

- Fix tz in calculated name - Fix tests - Add event sessions count to reports - Fixes computing update of stored value - Fixes views and reports - Fixes generator not creating last day sessions - Totalizations in session tree view - Security config - Adds es_ES translations - Fixes seats limits on sessions

- Fix report query - Adds progress bar to sessions tree view - Improves tests - Fixes seats limit check

Currently translated at 100.0% (103 of 103 strings) Translation: event-10.0/event-10.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-10-0/event-10-0-event_session/nl/

daramousk · 2018-11-28T15:19:08Z

event_session/models/event.py

+        string='Total event sessions',
+        store=True,
+    )
+    seats_expected = fields.Integer(store=True)


Is the store=True needed here? Since this is not a computed field.

event_session/__init__.py

NL66278 · 2018-11-28T15:27:11Z

event_session/__manifest__.py

+    'author': 'Tecnativa, '
+              'Odoo Community Association (OCA)',
+    "license": "AGPL-3",
+    'website': 'https://odoo-community.org/',


https://github.com/oca/event.git

NL66278 · 2018-11-28T15:27:37Z

event_session/models/__init__.py

@@ -0,0 +1,3 @@
+


license line

NL66278 · 2018-11-28T15:28:06Z

event_session/models/event.py

@@ -0,0 +1,46 @@
+# Copyright 2017 David Vidal<david.vidal@tecnativa.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).


And license lines should be https now also.

NL66278 · 2018-11-28T15:29:11Z

event_session/models/event.py

+        string='Total event sessions',
+        store=True,
+    )
+    seats_expected = fields.Integer(store=True)


No need any more for seats_expected and seats_available expected (nor for the corresponding functions).

@ntsirintanis What's the reason behind introducing this in the event object?

@chienandalu Ah, that's remnant from some experimentation I did with the module. Thanks for spotting this, I have pushed a new commit that removes this overwrite.

NL66278 · 2018-11-28T15:30:45Z

event_session/models/event_session.py

+        comodel_name='event.event',
+        string='Event',
+    )
+    seats_min = fields.Integer(


Do away with the seats stuff

event_session/tests/test_session.py

pedrobaeza · 2018-11-28T15:34:50Z

Sorry, but you can't rip off all that features from the module. They are needed the same as you have the event module as only one module, not event and event_registration, so 👎 to this migration while it doesn't preserve all the features we added in v10.

NL66278 · 2018-11-28T15:42:37Z

@pedrobaeza For us, and probably others, the idea of sessions is that you have one event where you register for (for instance a python course), but that is spread out over sessions (let us say for seven weeks). You do not register for each separate lesson.

But I do understand what you are saying. The usecase of the original authors of the module would be probably be to use an event as a kind of template, to generate several sessions with separate registration etc. Although I do not quite see why you would not generate events then and not sessions.

Would it be a solution to do the migration by renaming the module migrated/changed by @ntsirintanis into event_session_base, and then have event_session extend this to add the concepts of separate registration/availability etc.?

pedrobaeza · 2018-11-28T15:53:45Z

@NL66278 we are the original authors of the module, so I have very clear what is the goal of the module ;) It's not that, it's for having the concept of session, which is another pass of the same event. For example, of theater shows, cinema, and so on, so registration is perfectly fit for doing that at session level.

What you are saying is that you pretend to use this as tracks, not sessions, so this is not intended for that.

And we designed this to have the opportunity to register to an event or to a session, so these features don't block you usage, and so you shouldn't split out this.

NL66278 · 2018-11-29T08:57:31Z

@pedrobaeza I agree then that we will have to provide the full migration. For now consider it as a work in progress. The underlying code for registrations changed a lot, so this will take more time. FYI we looked at tracks but they did not fit our usecase. Tracks are more things happening in parallel, like all the different tracks at the Odoo days.

pedrobaeza · 2018-11-29T09:02:09Z

OK, thanks for reconsidering it. I have used in the past tracks for both things: parallel and linear "sessions", but of course it depends on the rest of requirements you have for that sessions. If you share them, maybe we can do a brain-storming about this.

ntsirintanis · 2018-12-06T16:11:36Z

I have gradually reintroduced all features that were removed for the initial PR. Please take a look @NL66278

alexschubert

Thanks for your contribution!

During functional testing, the following error appeared when trying to add a session to a newly created event:

Uncaught Error: KeyError: 'id'
http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:369
Traceback:
Error: KeyError: 'id'
at F.getitem (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:369:161)
at F.getattr (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:370:69)
at F.getattribute (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:203:38)
at Object.py.PY_getAttr (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:167:176)
at Object.py.evaluate (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:270:11)
at Object.py.evaluate (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:265:111)
at Object.py.evaluate (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:267:99)
at Object.py.eval (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:272:284)
at http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/418-c35d703/web.assets_backend.js:380:136
at Function..each..forEach (http://3349535-127-b590c5.runbot3.odoo-community.org/web/content/412-150dd49/web.assets_common.js:12:558)

Steps to reproduce:

Open the "Events" module
Click on the "Create" action
Without editing the event any further, add a session to the "Email Schedule" notebook page
Click on the Session dropdown
The error appears

Apart from this error, I was able to validate the general functionality of the module in addition to features like separate session registration and seat availability per session.

models, coverage increased

ntsirintanis · 2019-01-15T15:32:19Z

@alexschubert Thanks a lot for your review and the time spent testing the module. I have corrected the error by hiding event_mail_ids tree if there are no sessions associated to the event. This is different than 10.0, where one could actually create a session without having an event record. The way it is implemented now is more logical and clear in my opinion.

chienandalu

Looks good (code and runbot). Just a minor comment:

event_session/views/event_session_view.xml

ntsirintanis · 2019-02-19T16:12:37Z

@chienandalu Thanks for your review and suggestion. Event_session has an option for pivot view now.

…ent.

NL66278

Tested in practice and looks good to me.

chienandalu and others added 9 commits November 21, 2018 16:48

[ADD] event_session: New module

d50e096

[IMP] event_session: Several improvements:

7c4e97a

* Rename 'date' to 'date_begin' for being homogeneous with event fields * Split tests * Remove 'start_time' and 'end_time' as no needed * Convert hours to UTC for avoiding timezone issues

[IMP] event_session: Better info in registration reports

3df32b2

[FIX] event_session: Use new SQL view

9561ecf

[FIX][IMP] event_session: Several improvements:

cb8b552

- Fix report query - Adds progress bar to sessions tree view - Improves tests - Fixes seats limit check

[UPD] Update event_session.pot

1f45e65

Added translation using Weblate (Dutch)

8b0eada

Translated using Weblate (Dutch)

94f0c1f

Currently translated at 100.0% (103 of 103 strings) Translation: event-10.0/event-10.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-10-0/event-10-0-event_session/nl/

pedrobaeza added this to the 11.0 milestone Nov 28, 2018

pedrobaeza mentioned this pull request Nov 28, 2018

Migration to version 11.0 #91

Closed

15 tasks

pedrobaeza added the needs review label Nov 28, 2018

ntsirintanis force-pushed the 11.0-mig-event_session branch 2 times, most recently from f0db268 to 5585ec1 Compare November 28, 2018 14:59

daramousk reviewed Nov 28, 2018

View reviewed changes

NL66278 reviewed Nov 28, 2018

View reviewed changes

event_session/__init__.py Show resolved Hide resolved

NL66278 reviewed Nov 28, 2018

View reviewed changes

event_session/models/__init__.py Outdated

@@ -0,0 +1,3 @@

Copy link

NL66278 Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license line

NL66278 reviewed Nov 28, 2018

View reviewed changes

event_session/tests/test_session.py Show resolved Hide resolved

[MIG] event_session: Migration to 11.0

a0efbd4

ntsirintanis force-pushed the 11.0-mig-event_session branch from 5585ec1 to a0efbd4 Compare November 28, 2018 16:02

[WIP][ADD] Reintroduced session registration and mail scheduling

fabaf8c

ntsirintanis force-pushed the 11.0-mig-event_session branch 5 times, most recently from 47171fe to b590c55 Compare December 6, 2018 14:29

alexschubert suggested changes Dec 7, 2018

View reviewed changes

ntsirintanis force-pushed the 11.0-mig-event_session branch from b590c55 to 137f8a3 Compare January 15, 2019 14:58

[WIP][ADD] reintroduced seat calculations, added security for new

2553aad

models, coverage increased

ntsirintanis force-pushed the 11.0-mig-event_session branch from 137f8a3 to 2553aad Compare January 15, 2019 15:04

chienandalu reviewed Feb 18, 2019

View reviewed changes

event_session/views/event_session_view.xml Outdated Show resolved Hide resolved

[ADD] pivot view for event_session

cb6c301

[FIX] Removed unneeded overwrite for seats_expected field in event.ev…

57df6c4

…ent.

NL66278 approved these changes Mar 19, 2019

View reviewed changes

chienandalu approved these changes Mar 20, 2019

View reviewed changes

pedrobaeza merged commit c1290e8 into OCA:11.0 Mar 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0] [MIG] event_session #127

[11.0] [MIG] event_session #127

ntsirintanis commented Nov 28, 2018

daramousk Nov 28, 2018

NL66278 Nov 28, 2018

NL66278 Nov 28, 2018

NL66278 Nov 28, 2018

NL66278 Nov 28, 2018

chienandalu Feb 20, 2019

ntsirintanis Feb 20, 2019

NL66278 Nov 28, 2018

pedrobaeza commented Nov 28, 2018

NL66278 commented Nov 28, 2018

pedrobaeza commented Nov 28, 2018

NL66278 commented Nov 29, 2018

pedrobaeza commented Nov 29, 2018

ntsirintanis commented Dec 6, 2018

alexschubert left a comment

ntsirintanis commented Jan 15, 2019

chienandalu left a comment

ntsirintanis commented Feb 19, 2019

NL66278 left a comment

		@@ -0,0 +1,46 @@
		# Copyright 2017 David Vidal<david.vidal@tecnativa.com>
		# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

[11.0] [MIG] event_session #127

[11.0] [MIG] event_session #127

Conversation

ntsirintanis commented Nov 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 28, 2018

NL66278 commented Nov 28, 2018

pedrobaeza commented Nov 28, 2018

NL66278 commented Nov 29, 2018

pedrobaeza commented Nov 29, 2018

ntsirintanis commented Dec 6, 2018

alexschubert left a comment

Choose a reason for hiding this comment

ntsirintanis commented Jan 15, 2019

chienandalu left a comment

Choose a reason for hiding this comment

ntsirintanis commented Feb 19, 2019

NL66278 left a comment

Choose a reason for hiding this comment