Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] event_sale_session: Migration to 12.0 #137

Merged
merged 2 commits into from May 23, 2019
Merged

[12.0] event_sale_session: Migration to 12.0 #137

merged 2 commits into from May 23, 2019

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Mar 21, 2019 •
edited by pedrobaeza

Depends on:

Adds the option of choosing a session when selling an event ticket.

cc @Tecnativa

@pedrobaeza pedrobaeza added this to the 12.0 milestone Mar 21, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 21, 2019
Closed
24 tasks
pedrobaeza
pedrobaeza approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@chienandalu chienandalu force-pushed the 12.0-mig-event_sale_session branch 2 times, most recently from 7ef7399 to 9a7c4ac Compare May 8, 2019 11:17
Tardo
Tardo suggested changes May 9, 2019
View reviewed changes
event_sale_session/models/event_event.py Outdated Show resolved Hide resolved
event_sale_session/models/sale_order.py Outdated Show resolved Hide resolved
event_sale_session/models/sale_order.py Outdated Show resolved Hide resolved
@chienandalu chienandalu force-pushed the 12.0-mig-event_sale_session branch from 9a7c4ac to 7bcfea7 Compare May 9, 2019 12:31
@chienandalu
Copy link
Member Author

@Tardo Thanks for your review. I just added your suggestions

@pedrobaeza
Copy link
Member

Please rebase

@chienandalu chienandalu marked this pull request as ready for review May 10, 2019 14:17
@chienandalu
Copy link
Member Author

Already green

@pedrobaeza
Copy link
Member

@Tardo please finish your review

Tardo
Tardo approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code: LGTM

@chienandalu
Copy link
Member Author

This is awaiting final blessing :)

@pedrobaeza pedrobaeza merged commit b27efe4 into OCA:12.0 May 23, 2019
@pedrobaeza pedrobaeza deleted the 12.0-mig-event_sale_session branch May 23, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chienandalu @pedrobaeza @Tardo @OCA-git-bot