[11.0][MIG] website event require login #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
suggested changes
Apr 9, 2019
|
Yes, the day I finally quit MS Visual Studio I'll open my best bottle of champagne, but as long as I continue programming for SolidWorks, I have no choice to change. Some time ago I created a PR to add those files to gitignore OCA/maintainer-tools#316 (it is approved and merged) and it has been moved to other repositories like OCA / project where I usually collaborate more. But it has not been extended to the rest of the OCA repositories. |
daramousk
reviewed
Apr 12, 2019
chienandalu
suggested changes
May 10, 2019
There was a problem hiding this comment.
Please, @Change2improve, get rid of those .vs/* files so this can be approved 👍
emagdalenaC2i
force-pushed
the
11.0-mig-website_event_require_login
branch
from
d148907
to
28f2e6f
Compare
|
@chienandalu done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.