Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12.0 mig website event require login #149

Merged
merged 3 commits into from
May 27, 2019
Merged

12.0 mig website event require login #149

merged 3 commits into from
May 27, 2019

Conversation

Change2improve
Copy link

No description provided.

@emagdalenaC2i emagdalenaC2i force-pushed the 12.0-mig-website_event_require_login branch from 082827d to 77e9311 Compare May 22, 2019 03:03
@emagdalenaC2i emagdalenaC2i mentioned this pull request May 22, 2019
Closed
24 tasks
@emagdalenaC2i
Copy link
Contributor

@chienandalu and @pedrobaeza could you review this PR, thanks?

chienandalu
chienandalu suggested changes May 22, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Change2improve Tested on runbot and it works fine

You should regenerate readme parts so the version is bumped

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 22, 2019
@emagdalenaC2i
Copy link
Contributor

@chienandalu I think that the readme is generated automatically.
I tried to install the readme generator of maintainer-tools but it seems that it doesn't work well.
Next week in the code sprint I will try again

@chienandalu
Copy link
Member

Well, I think that you can edit the README.rst manually anyway (just bump the 11.0 to 12.0)

@pedrobaeza
Copy link
Member

The README is generated when the PR is merged, but it's true it's ugly now to see 11.0 in the code and can be misleading. Any way, don't worry too much about that.

@emagdalenaC2i
Copy link
Contributor

@pedrobaeza and @chienandalu So, Should I edit the readme or could you review and approve this PR?

@pedrobaeza pedrobaeza force-pushed the 12.0-mig-website_event_require_login branch from 77e9311 to 0732249 Compare May 27, 2019 09:51
@pedrobaeza
Copy link
Member

I have made some squashing and generate the README for you.

chienandalu
chienandalu approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @Change2improve 👍

@pedrobaeza pedrobaeza merged commit 05c258b into OCA:12.0 May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Change2improve @emagdalenaC2i @chienandalu @pedrobaeza