Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12.0 mig event_project #151

Merged
merged 24 commits into from
Jun 7, 2019
Merged

12.0 mig event_project #151

merged 24 commits into from
Jun 7, 2019

Conversation

ernestotejeda
Copy link
Member

  • Readme by fragments

Cc @Tecnativa

Endika Iglesias and others added 22 commits May 22, 2019 17:08
@ernestotejeda
[ADD] Add new addon event_project
a1ea12c
@ernestotejeda
[ADD] lang
f602b34
@ernestotejeda
[FIX]
01c284e
@ernestotejeda
[UPDATE] README
66044b1
@ernestotejeda
[UPDATE] README and add project_project model.
f2214a8
@ernestotejeda
[UPDATE] multiple update
8c4318d
@ernestotejeda
[UPDATE]
45925be
@ernestotejeda
[UPDATE] README
ac90693
@ernestotejeda
[UPDATE] "Done tasks shouldn't be moved."
9fdef57
@ernestotejeda
[UPDATE]
eacb64f 
-You don't need this instruction now
-Don't browse a recordset! self.env.ref already returns the recordset.
-This should be project_task_type_done.id
@sbidoul @ernestotejeda
[UPD] prefix versions with 8.0
8878a1d
@sysadminmatmoz @ernestotejeda
Slovene translations added
c8976b4
@pedrobaeza @ernestotejeda
[MIG] Make modules uninstallable
c479c9e
@pedrobaeza @ernestotejeda
[MIG] Rename manifest files
f25650f
@antespi @ernestotejeda
Refactor using event_recalculate addon
f25d42c
@antespi @ernestotejeda
Bufixes in event to project sync
ccf9261
@pedrobaeza @ernestotejeda
event_project: Cancel project when cancelling event
7c3ae6f
@chienandalu @ernestotejeda
[MIG] event_project: Migration to 10.0
117f2df
@pedrobaeza @ernestotejeda
[FIX] event_project: Fix tests + multi-record aware
fd57274
@chienandalu @ernestotejeda
[10.0][FIX] event_project: project name (OCA#92)
219803c
@oca-travis @ernestotejeda
[UPD] Update event_project.pot
6e8c0c1
@DarioLodeiros @ernestotejeda
Translated using Weblate (Spanish)
0dadd7c 
Currently translated at 100,0% (8 of 8 strings)

Translation: event-10.0/event-10.0-event_project
Translate-URL: https://translation.odoo-community.org/projects/event-10-0/event-10-0-event_project/es/
@oca-clabot
Copy link

Hey @ernestotejeda, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@yajo yajo added this to the 12.0 milestone May 24, 2019
@yajo
Copy link
Member

yajo commented May 24, 2019

I set as WIP until merged OCA/project#540:

odoo.exceptions.UserError: ("You try to install module 'event_project' that depends on module 'project_recalculate'.\nBut the latter module is not available in your system.", '')

@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 1, 2019
Closed
24 tasks
chienandalu
chienandalu reviewed Jun 7, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ernestotejeda OCA/project#540 is already merged. Add oca dependencies with the project repo as well

chienandalu
chienandalu approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and runbot testing 👍

Just some tiny suggestions:

event_project/__manifest__.py Outdated Show resolved Hide resolved
event_project/models/__init__.py Outdated Show resolved Hide resolved
event_project/models/project_project.py Outdated Show resolved Hide resolved
event_project/models/project_task.py Outdated Show resolved Hide resolved
event_project/tests/__init__.py Outdated Show resolved Hide resolved
@emagdalenaC2i
Copy link
Contributor

Code review and tested in runbot

I don't know if that is the workflow wanted, but reading the USAGE file seems that the selected project will change its name and end date. But testing in runbot it makes a copy of the selected project

@ernestotejeda if this is the workflow wanted you should edit USAGE.rst

emagdalenaC2i
emagdalenaC2i approved these changes Jun 7, 2019
View reviewed changes
event_project/readme/USAGE.rst Outdated

#. Create a project or duplicate an existing one that fits your needs.
#. Go to an event or create a brand new one and assign the previous project.
#. The project will inherit its name and will fit its end date to the begging of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new project will be created that will inherit the name of the selected project plus the dates of the event.
The new project will fit its end date to the end date of the event.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the usage description, could you review it?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ernestotejeda and others added 2 commits June 7, 2019 15:40
@ernestotejeda
[MIG] event_project: Migration to 12.0
cdcdeb2
@ernestotejeda @chienandalu
Apply suggestions from code review
0136030 
Co-Authored-By: David Vidal <david.vidal@tecnativa.com>
@ernestotejeda
Copy link
Member Author

Changes done

@pedrobaeza pedrobaeza merged commit 7aa570c into OCA:12.0 Jun 7, 2019
@pedrobaeza pedrobaeza deleted the 12.0-mig-event_project branch June 7, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@emagdalenaC2i emagdalenaC2i emagdalenaC2i approved these changes

Assignees
No one assigned
Labels
approved ready to merge work in progress
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet