[13.0][MIG] event_session #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename 'date' to 'date_begin' for being homogeneous with event fields * Split tests * Remove 'start_time' and 'end_time' as no needed * Convert hours to UTC for avoiding timezone issues
- Fix tz in calculated name - Fix tests - Add event sessions count to reports - Fixes computing update of stored value - Fixes views and reports - Fixes generator not creating last day sessions - Totalizations in session tree view - Security config - Adds es_ES translations - Fixes seats limits on sessions
- Fix report query - Adds progress bar to sessions tree view - Improves tests - Fixes seats limit check
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-event_session/
The big issue with this kind of code is that if you have a user with a certain locale being used, it will override the locale system wide and the next request on the server may have the dates formatted with strftime in a different language than expected... The other issue is that some systems do not provide a set of actual locales so on a server running in docker without manually modifying a dockerfile to install a set of locales, it may fail to switch the locale to a non existing one. It will just fail to compute the field. Babel is already a dependency of odoo and it's a bit strange to not use it. Get the locale the same way ir.qweb.fields do This commit use the same method as ir.qweb.fields to get the locale to use to translate a date. The previous code didn't took into account a case where the lang is undefined and this case also use the same default language as defined in odoo en_US. As a result, the behaviour of event_session is more in line with the current behaviour in odoo which is to default to en_US if locale is undefined. With the global locale setting, the default locale would be the system one so it may give different result or strange behaviours or simply prevent correctly working without manual intervention on the host.. While babel is already supported and used by odoo. Modified the test to actually test correctly the date formatted As the default lang is en_US the format of a date is the following: - month/day/year And time format is on 12 hours so not 22:00 to 23:00 but 10:00 PM to 11:00 PM With those changes, setting the locale to en_UK,en_CA will render the correct date using - day/month/year and hours on 24h. Added tests to confirm the translations work correctly on some locales Check case when locale=None should default to en_US Check that lang change is correctly taken into account. Check that it works with languages returning unicode text (Russian)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-event_session/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-event_session/
dalonsod
force-pushed
the
13.0-mig-event_session
branch
3 times, most recently
from
ea0d319
to
1bff4df
Compare
|
@chienandalu @sergio-teruel could you review? Thanks! |
chienandalu
reviewed
Apr 5, 2021
dalonsod
force-pushed
the
13.0-mig-event_session
branch
from
1bff4df
to
73b42c9
Compare
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 69732a3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration. Depends on #194