Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] event_mail: Migration to 14.0 #238

Merged
merged 10 commits into from
Dec 23, 2021

Conversation

ernestotejeda
Copy link
Member

Cc @Tecnativa TT32127

Main changes:

  • Adapt code to the use of computed writable

@ernestotejeda
Copy link
Member Author

@sergio-teruel @chienandalu could you review, please?

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

for scheduler in self.event_mail_template_id.scheduler_template_ids:
vals.append(
@api.depends("event_mail_template_id")
def _compute_event_mail_ids(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking here but you could do this to split the water, it's slightly cleaner:

records = self.filtered("event_mail_template_id")
without_template = self - records

@ernestotejeda
Copy link
Member Author

@ivantodorovich changes done

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration event_mail

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Dec 23, 2021
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-238-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 23, 2021
13 tasks
@OCA-git-bot OCA-git-bot merged commit f4f00bd into OCA:14.0 Dec 23, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 235e869. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants