[13.0][MIG] crm_event: Migration to 13.0 #240
Conversation
pedrobaeza
changed the title
|
Can you please squash together these commits?
And then you can proceed to merge (or tell me for me doing it). |
This module extends the functionality of CRM opportunities (and leads, if enabled) to support linking them to event types and to allow you to keep track of leads interested in an upcoming event of some type. This is useful if you organize your events based on the amount of people interested in a certain type of event. @Tecnativa TT27664 [UPD] Update crm_event.pot [UPD] README.rst [ADD] icon.png
- Upstream merged both lead and opportunity form views. @Tecnativa TT31318
yajo
force-pushed
the
13.0-mig-crm_event
branch
from
85121e7
to
055cdcc
Compare
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at b23417e. Thanks a lot for contributing to OCA. ❤️ |
| def init(self): | ||
| """(Re-)create report view.""" | ||
| tools.drop_view_if_exists(self.env.cr, self._table) | ||
| # pylint: disable=sql-injection |
There was a problem hiding this comment.
@yajo Why disabling this as it was correct? You should pass query params to the second argument of execute().
There was a problem hiding this comment.
In this case I can't do it through params, because that would escape the SQL code. I need to execute the raw SQL code instead, as this is meant to create a SQL view. So, this is a false positive problem.
However thanks for raising the question, it reflects you reviewed thoroughly.
|
/ocabot migration crm_event |
@Tecnativa TT31318