[MIG] event_session: Migration to 14.0 #263

chienandalu · 2022-03-16T16:46:11Z

Migration highlights:

event has changed the state field for a relation to configurable stages. We had to adapt to this new workflow.
Some old features were dropped as obsolete, so we drop them from event sessions as well (seats_min).
event_event.seats_availability select field changed to the new seats_limited boolean one. We adopt the same change in event sessions and a migration scrip is added to convert the data.
Record rules are updated to adapt to the new multicompany behavior.
Some fixes in tests.

please review @ernestotejeda @pedrobaeza

* Rename 'date' to 'date_begin' for being homogeneous with event fields * Split tests * Remove 'start_time' and 'end_time' as no needed * Convert hours to UTC for avoiding timezone issues

- Fix tz in calculated name - Fix tests - Add event sessions count to reports - Fixes computing update of stored value - Fixes views and reports - Fixes generator not creating last day sessions - Totalizations in session tree view - Security config - Adds es_ES translations - Fixes seats limits on sessions

- Fix report query - Adds progress bar to sessions tree view - Improves tests - Fixes seats limit check

The big issue with this kind of code is that if you have a user with a certain locale being used, it will override the locale system wide and the next request on the server may have the dates formatted with strftime in a different language than expected... The other issue is that some systems do not provide a set of actual locales so on a server running in docker without manually modifying a dockerfile to install a set of locales, it may fail to switch the locale to a non existing one. It will just fail to compute the field. Babel is already a dependency of odoo and it's a bit strange to not use it. Get the locale the same way ir.qweb.fields do This commit use the same method as ir.qweb.fields to get the locale to use to translate a date. The previous code didn't took into account a case where the lang is undefined and this case also use the same default language as defined in odoo en_US. As a result, the behaviour of event_session is more in line with the current behaviour in odoo which is to default to en_US if locale is undefined. With the global locale setting, the default locale would be the system one so it may give different result or strange behaviours or simply prevent correctly working without manual intervention on the host.. While babel is already supported and used by odoo. Modified the test to actually test correctly the date formatted As the default lang is en_US the format of a date is the following: - month/day/year And time format is on 12 hours so not 22:00 to 23:00 but 10:00 PM to 11:00 PM With those changes, setting the locale to en_UK,en_CA will render the correct date using - day/month/year and hours on 24h. Added tests to confirm the translations work correctly on some locales Check case when locale=None should default to en_US Check that lang change is correctly taken into account. Check that it works with languages returning unicode text (Russian)

When we create a session with seats_max = 0, we get an error when we try to view it. Doing this changes we achieve to avoid None values on the fields seats_available and seats_available_pc

Attendee count is failing because records are being accumulated without taking into account possible changes in event.registration With these changes, it is possible to correctly calculate the count of attendees. TT29930

pedrobaeza · 2022-03-18T00:53:02Z

/ocabot migration event_session

event_session/models/event_mail.py

OCA-git-bot · 2022-03-21T17:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2022-03-22T16:59:51Z

/ocabot merge nobump

OCA-git-bot · 2022-03-22T17:13:31Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-263-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2022-03-22T17:30:37Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-263-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2022-03-22T18:13:55Z

Travis is now red

pedrobaeza · 2022-03-22T18:14:34Z

It seems the depends you have re-added are not OK

ivantodorovich · 2022-03-22T18:20:26Z

event_session/models/event_mail.py

+        "session_id.date_begin",
+        "session_id.date_end",


You can keep only these two.
api.depends will add new ones when overriding, but it will keep the original ones

Thanks :) I'm never completly sure about that

event_session/migrations/14.0.1.0.0/pre-migration.py

event_session/models/event.py

event_session/models/event_mail.py

TT34351

chienandalu · 2022-03-24T16:04:54Z

@ernestotejeda can you update your review?

pedrobaeza · 2022-03-25T12:39:16Z

/ocabot merge nobump

OCA-git-bot · 2022-03-25T12:39:31Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-263-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-03-25T12:55:24Z

Congratulations, your PR was merged at b9b74b9. Thanks a lot for contributing to OCA. ❤️

chienandalu and others added 16 commits March 16, 2022 13:56

[ADD] event_session: New module

37ecd77

[IMP] event_session: Several improvements:

788a278

* Rename 'date' to 'date_begin' for being homogeneous with event fields * Split tests * Remove 'start_time' and 'end_time' as no needed * Convert hours to UTC for avoiding timezone issues

[IMP] event_session: Better info in registration reports

57702a7

[FIX] event_session: Use new SQL view

053413d

[FIX][IMP] event_session: Several improvements:

365ea14

- Fix report query - Adds progress bar to sessions tree view - Improves tests - Fixes seats limit check

Added translation using Weblate (Dutch)

9565faf

[MIG] event_session: Migration to 11.0

3732d00

[12.0] event_session: Migration to 12.0

4e1ccc9

[FIX] event_session: conflicting configuration

060ed9c

[IMP] event_session: black, isort, prettier

a809672

[MIG] event_session: Migration to 13.0

aa8da75

[FIX] event_session: Error when seats_max is 0

726f92e

When we create a session with seats_max = 0, we get an error when we try to view it. Doing this changes we achieve to avoid None values on the fields seats_available and seats_available_pc

[FIX] event_session: Attendee count failed

3418954

Attendee count is failing because records are being accumulated without taking into account possible changes in event.registration With these changes, it is possible to correctly calculate the count of attendees. TT29930

[IMP] event_session: black, isort, prettier

2771123

chienandalu force-pushed the 14.0-mig-event_session branch from ffd03ad to 74166fe Compare March 17, 2022 12:15

chienandalu marked this pull request as ready for review March 17, 2022 12:15

chienandalu mentioned this pull request Mar 17, 2022

[MIG] sale_event_session: Migration to 14.0 #264

Merged

1 task

OCA-git-bot added this to the 14.0 milestone Mar 18, 2022

OCA-git-bot mentioned this pull request Mar 18, 2022

Migration to version 14.0 #192

Closed

13 tasks

pedrobaeza approved these changes Mar 21, 2022

View reviewed changes

event_session/models/event_mail.py Outdated Show resolved Hide resolved

ivantodorovich approved these changes Mar 21, 2022

View reviewed changes

event_session/models/event_mail.py Outdated Show resolved Hide resolved

OCA-git-bot added approved ready to merge labels Mar 21, 2022

chienandalu force-pushed the 14.0-mig-event_session branch from 74166fe to 5652f8e Compare March 22, 2022 16:51

OCA-git-bot added a commit that referenced this pull request Mar 22, 2022

Merge PR #263 into 14.0

54c5b07

Signed-off-by pedrobaeza

OCA-git-bot added the bot is merging ⏳ label Mar 22, 2022

OCA-git-bot removed the bot is merging ⏳ label Mar 22, 2022

ivantodorovich reviewed Mar 22, 2022

View reviewed changes

ernestotejeda reviewed Mar 22, 2022

View reviewed changes

event_session/migrations/14.0.1.0.0/pre-migration.py Show resolved Hide resolved

event_session/models/event.py Outdated Show resolved Hide resolved

ernestotejeda reviewed Mar 22, 2022

View reviewed changes

event_session/models/event_mail.py Outdated Show resolved Hide resolved

[MIG] event_session: Migration to 14.0

fb86281

TT34351

chienandalu force-pushed the 14.0-mig-event_session branch from 5652f8e to fb86281 Compare March 23, 2022 09:31

chienandalu mentioned this pull request Mar 24, 2022

[MIG] event_session_registration_multi_qty: Migration to 14.0 #267

Merged

2 tasks

ernestotejeda approved these changes Mar 25, 2022

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 25, 2022

OCA-git-bot merged commit 39d3570 into OCA:14.0 Mar 25, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] event_session: Migration to 14.0 #263

[MIG] event_session: Migration to 14.0 #263

chienandalu commented Mar 16, 2022 •

edited

pedrobaeza commented Mar 18, 2022

OCA-git-bot commented Mar 21, 2022

pedrobaeza commented Mar 22, 2022

OCA-git-bot commented Mar 22, 2022

OCA-git-bot commented Mar 22, 2022

pedrobaeza commented Mar 22, 2022

pedrobaeza commented Mar 22, 2022

ivantodorovich Mar 22, 2022

chienandalu Mar 23, 2022

chienandalu commented Mar 24, 2022

pedrobaeza commented Mar 25, 2022

OCA-git-bot commented Mar 25, 2022

OCA-git-bot commented Mar 25, 2022

[MIG] event_session: Migration to 14.0 #263

[MIG] event_session: Migration to 14.0 #263

Conversation

chienandalu commented Mar 16, 2022 • edited

pedrobaeza commented Mar 18, 2022

OCA-git-bot commented Mar 21, 2022

pedrobaeza commented Mar 22, 2022

OCA-git-bot commented Mar 22, 2022

OCA-git-bot commented Mar 22, 2022

pedrobaeza commented Mar 22, 2022

pedrobaeza commented Mar 22, 2022

ivantodorovich Mar 22, 2022

Choose a reason for hiding this comment

chienandalu Mar 23, 2022

Choose a reason for hiding this comment

chienandalu commented Mar 24, 2022

pedrobaeza commented Mar 25, 2022

OCA-git-bot commented Mar 25, 2022

OCA-git-bot commented Mar 25, 2022

chienandalu commented Mar 16, 2022 •

edited