Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] [MIG] website_event_sale_hide_ticket: Migration to 15.0 (renamed to website_event_ticket_published) #281

Merged
merged 3 commits into from
Oct 26, 2022
Merged

[15.0] [MIG] website_event_sale_hide_ticket: Migration to 15.0 (renamed to website_event_ticket_published) #281

merged 3 commits into from
Oct 26, 2022

Conversation

Camille0907
Copy link

@Camille0907 Camille0907 commented Aug 10, 2022 •
edited
Loading

Migration of website_event_sale_hide_ticket (renamed to website_event_ticket_published) module from v13 to v15

@Camille0907 Camille0907 force-pushed the 15.0-mig-website_event_sale_hide_ticket branch from d29e2d4 to f5f8afb Compare August 10, 2022 14:10
@Camille0907 Camille0907 mentioned this pull request Aug 10, 2022
Open
16 tasks
@ivantodorovich
Copy link
Contributor

In 15.0, the event.ticket model has been moved from event_sale module to the event module.

This means the dependency could be changed to website_event (instead of website_event_sale), to support this feature even if event_sale is not installed. The module could then be renamed to website_event_hide_ticket (or maybe website_event_ticket_published for consistency with the website publish/unpublish concept in odoo).

Just a suggestion, not blocking

@Camille0907 Camille0907 force-pushed the 15.0-mig-website_event_sale_hide_ticket branch from f5f8afb to 31937e9 Compare October 26, 2022 08:06
@Camille0907 Camille0907 force-pushed the 15.0-mig-website_event_sale_hide_ticket branch from 31937e9 to 95258bf Compare October 26, 2022 08:07
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Camille0907 Camille0907 changed the title [15.0] [MIG] website_event_sale_hide_ticket: Migration to 15.0 [15.0] [MIG] website_event_sale_hide_ticket: Migration to 15.0 (renamed to website_event_ticket_published) Oct 26, 2022
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-281-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 43be0ff into OCA:15.0 Oct 26, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40bf968. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Camille0907 @ivantodorovich @OCA-git-bot @pedrobaeza @chienandalu @damdam-s