Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG]website_event_questions_by_ticket: Migration to 15.0 #289

Conversation

bizzappdev
Copy link

No description provided.

pedrobaeza and others added 12 commits December 29, 2022 15:05
This module allows to set that an event question is only asked for certain
tickets.

If the question is general, then having one of the allowed tickets will serve
for showing it. If the question is specific to each attendee, then the
evaluation will be done for each of the tickets.

Configuration
=============

1. Go to *Events > Events*
2. Create or select one event.
3. On the "Questions" page, create a new question or edit an existing one.
4. Fill the field "Limited to tickets" for restricting the question to that
   ticket. Leave it blank for making it available for all tickets.

Usage
=====

1. Go to the website.
2. Go to "Events" section and select one of them.
3. Select ticket quantity and click on "Register".
4. On the popup dialog, the questions linked to that ticket and those without
   restrictions will be shown.

Known issues / Roadmap
======================

* Add tests (tour) to the module.
Currently translated at 100.0% (4 of 4 strings)

Translation: event-13.0/event-13.0-website_event_questions_by_ticket
Translate-URL: https://translation.odoo-community.org/projects/event-13-0/event-13-0-website_event_questions_by_ticket/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: event-14.0/event-14.0-website_event_questions_by_ticket
Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-website_event_questions_by_ticket/
Currently translated at 71.4% (5 of 7 strings)

Translation: event-14.0/event-14.0-website_event_questions_by_ticket
Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-website_event_questions_by_ticket/it/
@pedrobaeza
Copy link
Member

It seems there's no migration commit, but everything on the pre-commit one.

@bizzappdev
Copy link
Author

It seems there's no migration commit, but everything on the pre-commit one.

It is in testing from our side and that is why it is in WIP. but mostly no further changes are needed to make it work in v15.
@pedrobaeza

@bizzappdev bizzappdev changed the title [WIP][15.0][MIG]website_event_questions_by_ticket: Migration to 15.0 [15.0][MIG]website_event_questions_by_ticket: Migration to 15.0 Jan 3, 2023
@bizzappdev
Copy link
Author

ready for the review

@bizzappdev bizzappdev force-pushed the 15.0-mig-website_event_questions_by_ticket-BAD-SIP branch from e0fae74 to d75b642 Compare March 20, 2023 13:07
Copy link
Contributor

@stefan-tecnativa stefan-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested 👍️

Just squash administrative commits and and all will be great.

@@ -4,7 +4,7 @@
{
"name": "Conditional Events Questions",
"summary": "Events Questions conditional to the chosen ticket",
"version": "14.0.1.0.0",
"version": "15.0.1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your migration commit message should be:

[MIG] website_event_questions_by_ticket: Migration to 15.0

@stefan-tecnativa
Copy link
Contributor

@bizzappdev what is the state of this task and this one #290 ??

@bizzappdev bizzappdev force-pushed the 15.0-mig-website_event_questions_by_ticket-BAD-SIP branch from 12d141a to 3684b26 Compare May 12, 2023 05:28
@bizzappdev
Copy link
Author

@bizzappdev what is the state of this task and this one #290 ??

It is also ready for the review.
and change for this MR is also done

@stefan-tecnativa
Copy link
Contributor

@bizzappdev can you please change the commit message to the one suggested?
[MIG] website_event_questions_by_ticket: Migration to 15.0

@pedrobaeza
Copy link
Member

As there's no significant change to be made, but the commit message is incorrect, superseding it by #307

@pedrobaeza pedrobaeza closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants